Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timestamp to filename for logs #3756

Merged

Conversation

Cali0707
Copy link
Member

On #3735 we discussed adding timestamps to the names for log files so that it is easy to see when the log collection started

Proposed Changes

  • Add timestamp to the log file names

Signed-off-by: Calum Murray <cmurray@redhat.com>
@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 12, 2024
@Cali0707
Copy link
Member Author

/cc @creydr @pierDipi

@knative-prow knative-prow bot requested review from creydr and pierDipi March 12, 2024 17:23
@Cali0707 Cali0707 changed the title Ddd timestamp to filename for logs Add timestamp to filename for logs Mar 12, 2024
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.43%. Comparing base (648f4f0) to head (d6f4721).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #3756   +/-   ##
=========================================
  Coverage     52.43%   52.43%           
  Complexity      874      874           
=========================================
  Files           342      342           
  Lines         21415    21415           
  Branches        284      284           
=========================================
  Hits          11229    11229           
  Misses         9276     9276           
  Partials        910      910           
Flag Coverage Δ
java-unittests 74.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

/retest

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2024
Copy link

knative-prow bot commented Mar 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@creydr
Copy link
Contributor

creydr commented Mar 13, 2024

/test reconciler-tests-namespaced-broker

@knative-prow knative-prow bot merged commit c195eb0 into knative-extensions:main Mar 13, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants