-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add timestamp to filename for logs #3756
Add timestamp to filename for logs #3756
Conversation
Signed-off-by: Calum Murray <cmurray@redhat.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3756 +/- ##
=========================================
Coverage 52.43% 52.43%
Complexity 874 874
=========================================
Files 342 342
Lines 21415 21415
Branches 284 284
=========================================
Hits 11229 11229
Misses 9276 9276
Partials 910 910
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/retest
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test reconciler-tests-namespaced-broker |
On #3735 we discussed adding timestamps to the names for log files so that it is easy to see when the log collection started
Proposed Changes