Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.12] Fix possible nil pointer dereferences on Consumer/ConsumerGroup #3774

Conversation

knative-prow-robot
Copy link
Contributor

This is an automated cherry-pick of #3631

Signed-off-by: Calum Murray <cmurray@redhat.com>
Signed-off-by: Calum Murray <cmurray@redhat.com>
@knative-prow knative-prow bot requested review from aliok and Cali0707 March 19, 2024 14:16
@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 19, 2024
@Cali0707
Copy link
Member

/cc @creydr @pierDipi

@knative-prow knative-prow bot requested review from creydr and pierDipi March 19, 2024 14:18
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 15.38462% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 48.75%. Comparing base (56b2bfc) to head (06a6a75).

Files Patch % Lines
control-plane/pkg/reconciler/consumer/consumer.go 20.00% 6 Missing and 2 partials ⚠️
...ls/kafka/eventing/v1alpha1/consumer_group_types.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.12    #3774      +/-   ##
================================================
- Coverage         48.78%   48.75%   -0.04%     
================================================
  Files               241      241              
  Lines             17422    17432      +10     
================================================
- Hits               8500     8499       -1     
- Misses             8219     8228       +9     
- Partials            703      705       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2024
Copy link

knative-prow bot commented Mar 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, knative-prow-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2024
@pierDipi
Copy link
Member

pierDipi commented Apr 2, 2024

/retest-required

@knative-prow knative-prow bot merged commit 09b81ea into knative-extensions:release-1.12 Apr 2, 2024
34 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants