Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove receiver-vertx and dispatcher-vertx modules #3791

Merged
merged 5 commits into from
Apr 30, 2024
Merged

Remove receiver-vertx and dispatcher-vertx modules #3791

merged 5 commits into from
Apr 30, 2024

Conversation

pierDipi
Copy link
Member

After #3557 we are using Loom modules, so we can now remove the old modules based on vertx-kafka-clients

@knative-prow knative-prow bot requested review from Cali0707 and matzew March 27, 2024 09:44
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 27, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.56%. Comparing base (551691c) to head (052d09b).
Report is 20 commits behind head on main.

Additional details and impacted files 
@@              Coverage Diff              @@
##               main    #3791       +/-   ##
=============================================
- Coverage     73.90%   49.56%   -24.34%     
=============================================
  Files           100      247      +147     
  Lines          3407    14866    +11459     
  Branches        288        0      -288     
=============================================
+ Hits           2518     7369     +4851     
- Misses          716     6742     +6026     
- Partials        173      755      +582
Flag Coverage Δ
java-unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pierDipi
Copy link
Member Author

/test channel-integration-tests-sasl-plain

@pierDipi
Copy link
Member Author

pierDipi commented Apr 3, 2024

/cc @Cali0707 @Leo6Leo @matzew @creydr

@knative-prow knative-prow bot requested review from creydr and Leo6Leo April 3, 2024 15:35
Cali0707
Cali0707 approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2024
@Leo6Leo
Copy link
Contributor

Leo6Leo commented Apr 3, 2024

/retest

@pierDipi
Copy link
Member Author

pierDipi commented Apr 4, 2024

/retest-required

4 similar comments
@pierDipi
Copy link
Member Author

pierDipi commented Apr 4, 2024

/retest-required

@Cali0707
Copy link
Member

Cali0707 commented Apr 5, 2024

/retest-required

@pierDipi
Copy link
Member Author

pierDipi commented Apr 8, 2024

/retest-required

@Cali0707
Copy link
Member

Cali0707 commented Apr 8, 2024

/retest-required

@matzew
Copy link
Contributor

matzew commented Apr 9, 2024

/test reconciler-tests

4 similar comments
@matzew
Copy link
Contributor

matzew commented Apr 9, 2024

/test reconciler-tests

@creydr
Copy link
Contributor

creydr commented Apr 10, 2024

/test reconciler-tests

@creydr
Copy link
Contributor

creydr commented Apr 10, 2024

/test reconciler-tests

@Cali0707
Copy link
Member

/test reconciler-tests

@Cali0707
Copy link
Member

/retest-required

@matzew
Copy link
Contributor

matzew commented Apr 15, 2024

/retest

@Cali0707
Copy link
Member

/retest-required

1 similar comment
@pierDipi
Copy link
Member Author

/retest-required

@creydr creydr mentioned this pull request Apr 22, 2024
Merged
@pierDipi
Copy link
Member Author

/test reconciler-tests

@pierDipi
Copy link
Member Author

/retest-required

@pierDipi
Copy link
Member Author

/retest

@creydr
Copy link
Contributor

creydr commented Apr 24, 2024

/retest-required

@creydr
Copy link
Contributor

creydr commented Apr 24, 2024

/test reconciler-tests

@creydr
Copy link
Contributor

creydr commented Apr 25, 2024

/test reconciler-tests-namespaced-broker

1 similar comment
@creydr
Copy link
Contributor

creydr commented Apr 25, 2024

/test reconciler-tests-namespaced-broker

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 25, 2024
@pierDipi
Remove receiver-vertx and dispatcher-vertx
71cf4ed 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi
Remove vertx-kafka-clients
6eddb6c 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi
Remove modules from docs and verify codegen
3d9f5e4 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi
Remove dispatcher-vertx from benchmark and tests
18cae49 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2024
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 30, 2024
@pierDipi
Copy link
Member Author

/cc @creydr @Cali0707

I rebased the PR since there were conflicts

@knative-prow knative-prow bot requested a review from Cali0707 April 30, 2024 13:03
@pierDipi
Add deps
052d09b 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Cali0707
Cali0707 approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Apr 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Cali0707
Copy link
Member

@pierDipi the upgrades should be fixed by #3868

@Cali0707
Copy link
Member

/test upgrade-tests

@Cali0707
Copy link
Member

/test channel-reconciler-tests-sasl-ssl

@knative-prow knative-prow bot merged commit b7b8880 into knative-extensions:main Apr 30, 2024
28 of 33 checks passed
creydr pushed a commit to creydr/knative-eventing-kafka-broker that referenced this pull request May 3, 2024
@pierDipi @creydr
Remove receiver-vertx and dispatcher-vertx modules (knative-extension…
bfcf3c6 
…s#3791)

* Remove receiver-vertx and dispatcher-vertx

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Remove vertx-kafka-clients

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Remove modules from docs and verify codegen

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Remove dispatcher-vertx from benchmark and tests

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Add deps

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

---------

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
openshift-merge-bot bot pushed a commit to openshift-knative/eventing-kafka-broker that referenced this pull request May 3, 2024
@creydr @pierDipi
[release-v1.14] Migrate to Loom-based modules (#1075)
70c0e67 
* Remove receiver-vertx and dispatcher-vertx modules (knative-extensions#3791)

* Remove receiver-vertx and dispatcher-vertx

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Remove vertx-kafka-clients

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Remove modules from docs and verify codegen

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Remove dispatcher-vertx from benchmark and tests

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Add deps

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

---------

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Update Dockerfiles

---------

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cali0707 Cali0707 Cali0707 approved these changes

@matzew matzew Awaiting requested review from matzew

@creydr creydr Awaiting requested review from creydr

@Leo6Leo Leo6Leo Awaiting requested review from Leo6Leo

Assignees

@Cali0707 Cali0707

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/data-plane lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@pierDipi @Leo6Leo @Cali0707 @matzew @creydr @knative-prow-robot