Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture reason for global resync #3818

Closed

Conversation

pierDipi
Copy link
Member

@pierDipi pierDipi commented Apr 5, 2024

As per title, helps with debugging flakes

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi
Copy link
Member Author

pierDipi commented Apr 5, 2024

/cc @Cali0707

@knative-prow knative-prow bot requested a review from Cali0707 April 5, 2024 08:46
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/control-plane labels Apr 5, 2024
@knative-prow knative-prow bot requested a review from aliok April 5, 2024 08:49
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 5, 2024
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 54.17%. Comparing base (551691c) to head (f5e1aad).
Report is 27 commits behind head on main.

Files Patch % Lines
...ol-plane/pkg/reconciler/trigger/v2/controllerv2.go 20.00% 3 Missing and 1 partial ⚠️
...l-plane/pkg/reconciler/consumergroup/controller.go 57.14% 2 Missing and 1 partial ⚠️
control-plane/pkg/reconciler/source/controller.go 83.33% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##               main    #3818       +/-   ##
=============================================
- Coverage     73.90%   54.17%   -19.74%     
  Complexity      876      876               
=============================================
  Files           100      346      +246     
  Lines          3407    18199    +14792     
  Branches        288      288               
=============================================
+ Hits           2518     9859     +7341     
- Misses          716     7416     +6700     
- Partials        173      924      +751     
Flag Coverage Δ
java-unittests 73.93% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pierDipi
Copy link
Member Author

pierDipi commented Apr 5, 2024

/retest-required

@pierDipi
Copy link
Member Author

pierDipi commented Apr 5, 2024

/test reconciler-tests-namespaced-broker

1 similar comment
@pierDipi
Copy link
Member Author

pierDipi commented Apr 5, 2024

/test reconciler-tests-namespaced-broker

@Cali0707
Copy link
Member

Cali0707 commented Apr 5, 2024

/retest

@Cali0707
Copy link
Member

Cali0707 commented Apr 5, 2024

/test all

@pierDipi
Copy link
Member Author

pierDipi commented Apr 8, 2024

/retest-required

3 similar comments
@pierDipi
Copy link
Member Author

pierDipi commented Apr 8, 2024

/retest-required

@pierDipi
Copy link
Member Author

pierDipi commented Apr 8, 2024

/retest-required

@pierDipi
Copy link
Member Author

pierDipi commented Apr 8, 2024

/retest-required

Copy link
Contributor

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2024
@matzew matzew closed this Apr 9, 2024
Copy link

knative-prow bot commented Apr 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matzew matzew reopened this Apr 9, 2024
@pierDipi
Copy link
Member Author

pierDipi commented Apr 9, 2024

/retest

@pierDipi
Copy link
Member Author

/retest-required

1 similar comment
@pierDipi
Copy link
Member Author

/retest-required

Copy link

knative-prow bot commented Apr 12, 2024

@pierDipi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
reconciler-tests-namespaced-broker_eventing-kafka-broker_main f5e1aad link true /test reconciler-tests-namespaced-broker
reconciler-tests_eventing-kafka-broker_main f5e1aad link true /test reconciler-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 30, 2024
@knative-prow-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Cali0707
Copy link
Member

@pierDipi do we still need this PR with the new flake fixes we merged?

@pierDipi pierDipi closed this Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants