Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Automated] Update eventing-kafka-broker-eventing nightly #3857

Conversation

knative-automation
Copy link
Contributor

@knative-automation knative-automation commented Apr 25, 2024

/assign @knative-extensions/eventing-wg-leads
/cc @knative-extensions/eventing-wg-leads

Produced via:

for x in eventing-crds.yaml eventing-core.yaml eventing-tls-networking.yaml; do
  curl https://storage.googleapis.com/knative-nightly/eventing/latest/$x > ${GITHUB_WORKSPACE}/./third_party/eventing-latest/$x
done

Details:

bumping knative.dev/eventing 4ba426c...4a3f65d:
  > 4a3f65d [main] Update community files (# 7876)
  > 46e3677 fix: imc dispatcher doesn't have duplicate reporting of metrics (# 7870)
  > e23ebab Reconcile trigger on OIDC service account changes only, if SA references a trigger for correct broker class (# 7849)
  > ea14296 fix: remove duplicate configMaps (# 7847)

Copy link

knative-prow bot commented Apr 25, 2024

@knative-automation: GitHub didn't allow me to request PR reviews from the following users: knative-extensions/eventing-wg-leads.

Note that only knative-extensions members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/assign @knative-extensions/eventing-wg-leads
/cc @knative-extensions/eventing-wg-leads

Produced via:

for x in eventing-crds.yaml eventing-core.yaml eventing-tls-networking.yaml; do
 curl https://storage.googleapis.com/knative-nightly/eventing/latest/$x > ${GITHUB_WORKSPACE}/./third_party/eventing-latest/$x
done

Details:

bumping knative.dev/eventing 4ba426c...e23ebab:
 > e23ebab Reconcile trigger on OIDC service account changes only, if SA references a trigger for correct broker class (# 7849)
 > ea14296 fix: remove duplicate configMaps (# 7847)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 25, 2024
Copy link
Contributor

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

/retest

@knative-prow knative-prow bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 26, 2024
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2024
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.58%. Comparing base (551691c) to head (3b24db4).
Report is 16 commits behind head on main.

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #3857       +/-   ##
=============================================
- Coverage     73.90%   49.58%   -24.33%     
=============================================
  Files           100      247      +147     
  Lines          3407    14866    +11459     
  Branches        288        0      -288     
=============================================
+ Hits           2518     7371     +4853     
- Misses          716     6741     +6025     
- Partials        173      754      +581     
Flag Coverage Δ
java-unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bumping knative.dev/eventing 4ba426c...4a3f65d:
  > 4a3f65d [main] Update community files (# 7876)
  > 46e3677 fix: imc dispatcher doesn't have duplicate reporting of metrics (# 7870)
  > e23ebab Reconcile trigger on OIDC service account changes only, if SA references a trigger for correct broker class (# 7849)
  > ea14296 fix: remove duplicate configMaps (# 7847)

Signed-off-by: Knative Automation <automation@knative.team>
Copy link
Contributor

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 30, 2024
Copy link

knative-prow bot commented Apr 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, knative-automation, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pierDipi
Copy link
Member

/retest-required

@knative-prow knative-prow bot merged commit 99cf1ab into knative-extensions:main Apr 30, 2024
29 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. skip-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants