-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Automated] Update eventing-kafka-broker-eventing nightly #3857
[Automated] Update eventing-kafka-broker-eventing nightly #3857
Conversation
@knative-automation: GitHub didn't allow me to request PR reviews from the following users: knative-extensions/eventing-wg-leads. Note that only knative-extensions members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/retest
49d4d43
to
1e88516
Compare
1e88516
to
cb55527
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3857 +/- ##
=============================================
- Coverage 73.90% 49.58% -24.33%
=============================================
Files 100 247 +147
Lines 3407 14866 +11459
Branches 288 0 -288
=============================================
+ Hits 2518 7371 +4853
- Misses 716 6741 +6025
- Partials 173 754 +581
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bumping knative.dev/eventing 4ba426c...4a3f65d: > 4a3f65d [main] Update community files (# 7876) > 46e3677 fix: imc dispatcher doesn't have duplicate reporting of metrics (# 7870) > e23ebab Reconcile trigger on OIDC service account changes only, if SA references a trigger for correct broker class (# 7849) > ea14296 fix: remove duplicate configMaps (# 7847) Signed-off-by: Knative Automation <automation@knative.team>
cb55527
to
3b24db4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, knative-automation, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required |
99cf1ab
into
knative-extensions:main
/assign @knative-extensions/eventing-wg-leads
/cc @knative-extensions/eventing-wg-leads
Produced via:
Details: