Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Remove hardcoded broker class from tests #3898

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pierDipi
Copy link
Member

This will actually run namespaced Broker tests

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@knative-prow knative-prow bot requested review from aliok and creydr May 15, 2024 10:21
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/test approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 15, 2024
@pierDipi
Copy link
Member Author

/cc @aliok @Cali0707

@knative-prow knative-prow bot requested a review from Cali0707 May 15, 2024 10:25
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.69%. Comparing base (aacc057) to head (6bf3024).
Report is 24 commits behind head on main.

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #3898       +/-   ##
=============================================
- Coverage     73.70%   49.69%   -24.02%     
=============================================
  Files           100      246      +146     
  Lines          3419    14849    +11430     
  Branches        292        0      -292     
=============================================
+ Hits           2520     7379     +4859     
- Misses          723     6711     +5988     
- Partials        176      759      +583     
Flag Coverage Δ
java-unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2024
Copy link

knative-prow bot commented May 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matzew
Copy link
Contributor

matzew commented May 22, 2024

/retest

Copy link

knative-prow bot commented May 22, 2024

@pierDipi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
upgrade-tests_eventing-kafka-broker_main 6bf3024 link true /test upgrade-tests
reconciler-tests-namespaced-broker_eventing-kafka-broker_main 6bf3024 link true /test reconciler-tests-namespaced-broker
reconciler-tests_eventing-kafka-broker_main 6bf3024 link true /test reconciler-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@pierDipi pierDipi changed the title Remove hardcoded broker class from tests [WIP] Remove hardcoded broker class from tests May 30, 2024
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants