Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to latest Kafka clients 3.7 #3900

Merged
merged 3 commits into from
Jun 6, 2024
Merged

Bump to latest Kafka clients 3.7 #3900

merged 3 commits into from
Jun 6, 2024

Conversation

pierDipi
Copy link
Member

As per title

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 15, 2024
@codecov Codecov
Copy link

codecov bot commented May 15, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.24%. Comparing base (8b4d147) to head (eb3fb87).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3900   +/-   ##
=======================================
  Coverage   48.24%   48.24%           
=======================================
  Files         246      246           
  Lines       14500    14500           
=======================================
  Hits         6995     6995           
  Misses       6799     6799           
  Partials      706      706

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

matzew
matzew reviewed May 16, 2024
View reviewed changes
...er/src/main/java/dev/knative/eventing/kafka/broker/dispatcher/impl/RecordDispatcherImpl.java
@@ -362,7 +362,7 @@ private ConsumerRecordContext maybeDeserializeValueFromHeaders(ConsumerRecordCon
// headers even though the record is a valid CloudEvent.
logDebug("Value is null", recordContext.getRecord());
final var value = cloudEventDeserializer.deserialize(
recordContext.getRecord().topic(), recordContext.getRecord().headers(), null);
recordContext.getRecord().topic(), recordContext.getRecord().headers(), (byte[]) null);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is b/c of here, right? apache/kafka#12545

@pierDipi
Bump to latest Kafka clients
66d5df5 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi
Fix compilation errors
6f5c8b4 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi
Copy link
Member Author

/retest

@pierDipi pierDipi changed the title [WIP] Bump to latest Kafka clients 3.7 Bump to latest Kafka clients 3.7 May 30, 2024
@pierDipi pierDipi requested a review from matzew May 30, 2024 07:49
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 30, 2024
@pierDipi pierDipi requested review from creydr and Cali0707 May 30, 2024 07:49
Cali0707
Cali0707 approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 30, 2024
@pierDipi
Copy link
Member Author

pierDipi commented Jun 3, 2024

/retest

@pierDipi
Copy link
Member Author

pierDipi commented Jun 3, 2024

/retest-required

@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 4, 2024
@pierDipi pierDipi requested a review from Cali0707 June 4, 2024 14:22
Cali0707
Cali0707 approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 4, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jun 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pierDipi
Copy link
Member Author

pierDipi commented Jun 6, 2024

/retest

@matzew
Copy link
Contributor

matzew commented Jun 6, 2024

/test reconciler-tests-namespaced-broker

@matzew
Copy link
Contributor

matzew commented Jun 6, 2024

/test upgrade-tests

@knative-prow knative-prow bot merged commit 7d14a4a into knative-extensions:main Jun 6, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cali0707 Cali0707 Cali0707 approved these changes

@lionelvillard lionelvillard Awaiting requested review from lionelvillard

@odacremolbap odacremolbap Awaiting requested review from odacremolbap

@matzew matzew Awaiting requested review from matzew

@creydr creydr Awaiting requested review from creydr

Assignees

@Cali0707 Cali0707

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/data-plane lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pierDipi @matzew @Cali0707