Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow different namespace references #3917

Merged

Conversation

pierDipi
Copy link
Member

@pierDipi pierDipi commented Jun 3, 2024

Allow having subscribers in different namespaces

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 3, 2024
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 49.24%. Comparing base (483904b) to head (dfa6385).
Report is 4 commits behind head on main.

Files Patch % Lines
control-plane/cmd/webhook-kafka/main.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3917   +/-   ##
=======================================
  Coverage   49.24%   49.24%           
=======================================
  Files         247      247           
  Lines       14925    14925           
=======================================
  Hits         7350     7350           
  Misses       6816     6816           
  Partials      759      759           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pierDipi pierDipi requested a review from Cali0707 June 3, 2024 10:49
@pierDipi
Copy link
Member Author

pierDipi commented Jun 3, 2024

/cherry-pick release-1.14

@knative-prow-robot
Copy link
Contributor

@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.14 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pierDipi
Copy link
Member Author

pierDipi commented Jun 3, 2024

/retest

@pierDipi
Copy link
Member Author

pierDipi commented Jun 3, 2024

/test reconciler-tests-namespaced-broker

Copy link
Member

@Cali0707 Cali0707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 3, 2024
Copy link

knative-prow bot commented Jun 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pierDipi
Copy link
Member Author

pierDipi commented Jun 3, 2024

/retest-required

1 similar comment
@Cali0707
Copy link
Member

Cali0707 commented Jun 3, 2024

/retest-required

@pierDipi
Copy link
Member Author

pierDipi commented Jun 3, 2024

@pierDipi
Copy link
Member Author

pierDipi commented Jun 4, 2024

/test reconciler-tests-namespaced-broker

@pierDipi
Copy link
Member Author

pierDipi commented Jun 4, 2024

/retest

@Cali0707
Copy link
Member

Cali0707 commented Jun 4, 2024

/retest-required

@matzew
Copy link
Contributor

matzew commented Jun 5, 2024

/test reconciler-tests-namespaced-broker

@pierDipi
Copy link
Member Author

pierDipi commented Jun 5, 2024

/retest

@knative-prow knative-prow bot merged commit 5c4b6a4 into knative-extensions:main Jun 5, 2024
36 of 37 checks passed
@knative-prow-robot
Copy link
Contributor

@pierDipi: new pull request created: #3924

In response to this:

/cherry-pick release-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants