-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow different namespace references #3917
Allow different namespace references #3917
Conversation
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3917 +/- ##
=======================================
Coverage 49.24% 49.24%
=======================================
Files 247 247
Lines 14925 14925
=======================================
Hits 7350 7350
Misses 6816 6816
Partials 759 759 ☔ View full report in Codecov by Sentry. |
/cherry-pick release-1.14 |
@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.14 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retest |
/test reconciler-tests-namespaced-broker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required |
1 similar comment
/retest-required |
/test reconciler-tests-namespaced-broker |
/test reconciler-tests-namespaced-broker |
/retest |
/retest-required |
/test reconciler-tests-namespaced-broker |
/retest |
5c4b6a4
into
knative-extensions:main
@pierDipi: new pull request created: #3924 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Allow having subscribers in different namespaces