Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: added channel KEDA scaling test #3925

Merged

Conversation

Cali0707
Copy link
Member

@Cali0707 Cali0707 commented Jun 5, 2024

Fixes #3239

Proposed Changes

  • Add rekt test for Kafka Channel KEDA scaling

@knative-prow knative-prow bot requested review from Leo6Leo and matzew June 5, 2024 15:22
@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test labels Jun 5, 2024
@Cali0707
Copy link
Member Author

Cali0707 commented Jun 5, 2024

/cc @pierDipi

@knative-prow knative-prow bot requested a review from pierDipi June 5, 2024 15:23
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2024
Copy link

knative-prow bot commented Jun 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Calum Murray <cmurray@redhat.com>
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2024
@pierDipi
Copy link
Member

pierDipi commented Jun 5, 2024

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2024
@knative-prow knative-prow bot merged commit 614c5d6 into knative-extensions:main Jun 5, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test Subscriptions autoscaling with KEDA
2 participants