Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only add authentication ref to scaled objects when there is an actual value to reference #3941

Merged
merged 1 commit into from
Jun 21, 2024
Merged

fix: only add authentication ref to scaled objects when there is an actual value to reference #3941

merged 1 commit into from
Jun 21, 2024

Conversation

Cali0707
Copy link
Member

Fixes #3939

Proposed Changes

  • Only add the authentication ref to the scaled object if there is something to reference

Release Note

:bug: KEDA ScaledObjects are now only created with an authentication ref if there is a trigger authentication object to reference

@Cali0707
fix: only add triggerAuth to scaled objects when there is an actual v…
7354011 
…alue to reference

Signed-off-by: Calum Murray <cmurray@redhat.com>
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/control-plane labels Jun 21, 2024
@Cali0707
Copy link
Member Author

/cc @pierDipi @creydr @maschmid

@Cali0707
Copy link
Member Author

/cherry-pick release-1.14

@knative-prow-robot
Copy link
Contributor

@Cali0707: once the present PR merges, I will cherry-pick it on top of release-1.14 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Cali0707
Copy link
Member Author

/cherry-pick release-1.13

@knative-prow-robot
Copy link
Contributor

@Cali0707: once the present PR merges, I will cherry-pick it on top of release-1.13 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

creydr
creydr approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Jun 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, creydr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 9b3f5f4 into knative-extensions:main Jun 21, 2024
34 of 35 checks passed
@knative-prow-robot
Copy link
Contributor

@Cali0707: new pull request created: #3942

In response to this:

/cherry-pick release-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

This was referenced Jun 21, 2024
Merged
Merged
@knative-prow-robot
Copy link
Contributor

@Cali0707: new pull request created: #3943

In response to this:

/cherry-pick release-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Cali0707 added a commit to Cali0707/eventing-kafka-broker that referenced this pull request Jun 21, 2024
@Cali0707
fix: only add triggerAuth to scaled objects when there is an actual v…
6317e2a 
…alue to reference (knative-extensions#3941)

Signed-off-by: Calum Murray <cmurray@redhat.com>
@Cali0707 Cali0707 mentioned this pull request Jun 21, 2024
Open
Cali0707 added a commit to Cali0707/eventing-kafka-broker that referenced this pull request Jun 21, 2024
@Cali0707
fix: only add triggerAuth to scaled objects when there is an actual v…
99f5558 
…alue to reference (knative-extensions#3941)

Signed-off-by: Calum Murray <cmurray@redhat.com>
@Cali0707 Cali0707 mentioned this pull request Jun 21, 2024
Merged
openshift-merge-bot bot pushed a commit to openshift-knative/eventing-kafka-broker that referenced this pull request Jul 8, 2024
@Cali0707
[release-v1.14] fix: only add triggerAuth to scaled objects when ther…
8cbbb1a 
…e is an actual value to reference (knative-extensions#3941) (#1119)

* fix: only add triggerAuth to scaled objects when there is an actual value to reference (knative-extensions#3941)

Signed-off-by: Calum Murray <cmurray@redhat.com>

* test: verify that scaledobjects have no authenticationref when it is empty (knative-extensions#3944)

Signed-off-by: Calum Murray <cmurray@redhat.com>

---------

Signed-off-by: Calum Murray <cmurray@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@creydr creydr creydr approved these changes

@Leo6Leo Leo6Leo Awaiting requested review from Leo6Leo

@maschmid maschmid Awaiting requested review from maschmid

@lionelvillard lionelvillard Awaiting requested review from lionelvillard

@pierDipi pierDipi Awaiting requested review from pierDipi

Assignees

@creydr creydr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
3 participants
@Cali0707 @knative-prow-robot @creydr