Non-blocking data plane components #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
knative-prow-robot
added
approved
Codecov Report
@@ Coverage Diff @@
## master #438 +/- ##
============================================
- Coverage 77.35% 77.14% -0.22%
Complexity 262 262
============================================
Files 59 59
Lines 1877 1877
Branches 83 83
============================================
- Hits 1452 1448 -4
- Misses 320 321 +1
- Partials 105 108 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
data-plane/receiver/src/main/java/dev/knative/eventing/kafka/broker/receiver/Main.java
Outdated
Show resolved
Hide resolved
...main/java/dev/knative/eventing/kafka/broker/dispatcher/http/HttpConsumerVerticleFactory.java
Outdated
Show resolved
Hide resolved
...main/java/dev/knative/eventing/kafka/broker/dispatcher/http/HttpConsumerVerticleFactory.java
Outdated
Show resolved
Hide resolved
...main/java/dev/knative/eventing/kafka/broker/dispatcher/http/HttpConsumerVerticleFactory.java
Outdated
Show resolved
Hide resolved
...main/java/dev/knative/eventing/kafka/broker/dispatcher/http/HttpConsumerVerticleFactory.java
Outdated
Show resolved
Hide resolved
...main/java/dev/knative/eventing/kafka/broker/dispatcher/http/HttpConsumerVerticleFactory.java
Outdated
Show resolved
Hide resolved
pierDipi
force-pushed
the
create-web-client-per-verticle
branch
from
3f1b0d2
to
0e1cee1
Compare
pierDipi
commented
Nov 27, 2020
data-plane/tests/src/test/java/dev/knative/eventing/kafka/broker/tests/DataPlaneTest.java
Outdated
Show resolved
Hide resolved
knative-prow-robot
added
the
do-not-merge/hold
Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
pierDipi
force-pushed
the
create-web-client-per-verticle
branch
from
0e1cee1
to
ba5f9da
Compare
|
/unhold |
knative-prow-robot
removed
the
do-not-merge/hold
|
@slinkydeveloper can we merge this? |
|
I wanted to do another pass, i'm on it |
slinkydeveloper
suggested changes
Dec 1, 2020
...lane/receiver/src/main/java/dev/knative/eventing/kafka/broker/receiver/ReceiverVerticle.java
Show resolved
Hide resolved
...lane/receiver/src/main/java/dev/knative/eventing/kafka/broker/receiver/ReceiverVerticle.java
Show resolved
Hide resolved
...main/java/dev/knative/eventing/kafka/broker/dispatcher/http/HttpConsumerVerticleFactory.java
Outdated
Show resolved
Hide resolved
...main/java/dev/knative/eventing/kafka/broker/dispatcher/http/HttpConsumerVerticleFactory.java
Outdated
Show resolved
Hide resolved
...main/java/dev/knative/eventing/kafka/broker/dispatcher/http/HttpConsumerVerticleFactory.java
Outdated
Show resolved
Hide resolved
pierDipi
force-pushed
the
create-web-client-per-verticle
branch
2 times, most recently
from
d9bd758
to
bd65169
Compare
Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
pierDipi
force-pushed
the
create-web-client-per-verticle
branch
from
bd65169
to
5a65fa0
Compare
slinkydeveloper
approved these changes
Dec 1, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pierDipi, slinkydeveloper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Can you lgtm? |
|
/lgtm Sorry i forgot it 😄 |
|
No problem :) |
pierDipi
added a commit
to pierDipi/eventing-kafka-broker
that referenced
this pull request
Feb 27, 2021
* Dispatcher non-blocking Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com> * Receiver non-blocking Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com> * Refactor our core factory and rename factories Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com> * Rename method, delete comments and use HashMap constructor Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
matzew
pushed a commit
to matzew/eventing-kafka-broker
that referenced
this pull request
Nov 4, 2022
…ensions#2720) (knative-extensions#438) We're setting it after a Consumer is created. Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sharing a
WebClientacross multiple verticles is discouraged byVertx, see https://vertx.io/docs/vertx-core/java/#_httpclient_usage.
That section talks about the HTTP Client, the
WebClientisn't different.Main changes are around when objects are built and in which Vertx context.
Proposed Changes
Release Note
/kind enhancement