Allow consumer group to be cancelled

[lionelvillard]

Proposed Changes

• 🐛 KafkaSource now properly close the session when the parent context is closed.

Release Note

🐛 KafkaSource now properly close the session when the parent context is closed.  

Docs

[lionelvillard]

@pierDipi @matzew I believe this one is ready to go, right?

[pierDipi]

/approve
/cc slinkydeveloper matzew

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lionelvillard, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [lionelvillard]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[lionelvillard]

/hold

[knative-metrics-robot]

The following is the coverage report on the affected files.
Say /test pull-knative-sandbox-eventing-kafka-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/source/adapter/adapter.go	65.0%	64.1%	-0.9

[codecov]

Codecov Report

Merging #100 into master will decrease coverage by 0.18%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master     #100      +/-   ##
==========================================
- Coverage   75.25%   75.07%   -0.19%     
==========================================
  Files         112      112              
  Lines        3997     3996       -1     
==========================================
- Hits         3008     3000       -8     
- Misses        806      813       +7     
  Partials      183      183              

Impacted Files	Coverage Δ
pkg/common/consumer/consumer_handler.go	80.95% <ø> (ø)
pkg/source/adapter/adapter.go	68.62% <50.00%> (-0.61%)	⬇️
pkg/channel/consolidated/dispatcher/dispatcher.go	48.79% <100.00%> (ø)
pkg/common/consumer/consumer_factory.go	77.41% <100.00%> (ø)
...el/distributed/dispatcher/dispatcher/dispatcher.go	66.29% <0.00%> (-7.87%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8325f1b...20dbada. Read the comment docs.

[lionelvillard]

I made this PR smaller.

/unhold

[slinkydeveloper]

So at this point this PR just adds the context to the signature of StartConsumerGroup right?

[lionelvillard]

right.

[slinkydeveloper]

So the description of the pr is wrong 😄

[lionelvillard]

description or title?

[slinkydeveloper]

both

[slinkydeveloper]

i mean, what if you fix the whole issue here or cancelling the consumer group with closing the context? This change is small enough and pretty clear

[knative-prow-robot]

@lionelvillard: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-knative-sandbox-eventing-kafka-integration-test-channel-distributed	20dbada	link	/test pull-knative-sandbox-eventing-kafka-integration-test-channel-distributed

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[knative-prow-robot]

@lionelvillard: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-knative-sandbox-eventing-kafka-integration-test-channel-consolidated	20dbada	link	/test pull-knative-sandbox-eventing-kafka-integration-test-channel-consolidated

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[lionelvillard]

will submit another PR.