Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

KafkaSource: expose dispatcher metrics and profiling data #221

Merged

Conversation

lionelvillard
Copy link
Contributor

Proposed Changes

Release Note

馃Ы The KafkaSource dispatchers now expose metrics and profiling information 

Docs

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 23, 2020
@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 23, 2020
@codecov
Copy link

codecov bot commented Nov 23, 2020

Codecov Report

Merging #221 (10d6edf) into master (4b0de1e) will decrease coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #221      +/-   ##
==========================================
- Coverage   76.10%   75.97%   -0.14%     
==========================================
  Files         114      114              
  Lines        4395     4399       +4     
==========================================
- Hits         3345     3342       -3     
- Misses        851      858       +7     
  Partials      199      199              
Impacted Files Coverage 螖
...rce/reconciler/source/resources/receive_adapter.go 100.00% <100.00%> (酶)
...el/distributed/dispatcher/dispatcher/dispatcher.go 66.05% <0.00%> (-6.43%) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 4b0de1e...10d6edf. Read the comment docs.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 26, 2020
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 26, 2021
@lionelvillard
Copy link
Contributor Author

/assign @aliok

@aliok
Copy link
Member

aliok commented Feb 4, 2021

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, lionelvillard

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [aliok,lionelvillard]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 51ff52a into knative-extensions:master Feb 4, 2021
matzew added a commit to matzew/eventing-kafka that referenced this pull request Jun 2, 2021
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants