New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
KafkaSource supports ceOverrides #811
KafkaSource supports ceOverrides #811
Conversation
Codecov Report
@@ Coverage Diff @@
## main #811 +/- ##
==========================================
- Coverage 75.22% 75.03% -0.19%
==========================================
Files 139 139
Lines 6377 6398 +21
==========================================
+ Hits 4797 4801 +4
- Misses 1354 1368 +14
- Partials 226 229 +3
Continue to review full report at Codecov.
|
a274ece
to
b6e6b44
Compare
The following is the coverage report on the affected files.
|
@lionelvillard: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/assign @matzew |
@matzew do you have time to TAL at this one? |
gentle ping. |
should I reassign to someone else @matzew ? |
|
||
type extensionAsTransformer map[string]string | ||
|
||
func (c extensionAsTransformer) Transform(r binding.MessageMetadataReader, w binding.MessageMetadataWriter) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would this be useful outside?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lionelvillard, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #804
Proposed Changes
ceOverrides
anymoreRelease Note
Docs