Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

KafkaSource supports ceOverrides #811

Merged

Conversation

lionelvillard
Copy link
Contributor

Fixes #804

Proposed Changes

  • KafkaSource does not ignore ceOverrides anymore

Release Note

馃巵 KafkaSource now supports ceOverrides.

Docs

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Aug 18, 2021
@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 18, 2021
@codecov
Copy link

codecov bot commented Aug 18, 2021

Codecov Report

Merging #811 (4f53abc) into main (fdf11c5) will decrease coverage by 0.18%.
The diff coverage is 30.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #811      +/-   ##
==========================================
- Coverage   75.22%   75.03%   -0.19%     
==========================================
  Files         139      139              
  Lines        6377     6398      +21     
==========================================
+ Hits         4797     4801       +4     
- Misses       1354     1368      +14     
- Partials      226      229       +3     
Impacted Files Coverage 螖
pkg/source/adapter/adapter.go 54.73% <0.00%> (-3.70%) 猬囷笍
pkg/source/mtadapter/adapter.go 46.61% <0.00%> (-1.22%) 猬囷笍
...rce/reconciler/source/resources/receive_adapter.go 96.51% <0.00%> (-3.49%) 猬囷笍
pkg/source/adapter/message.go 72.72% <60.00%> (-1.60%) 猬囷笍
test/rekt/resources/kafkasource/kafkasource.go 75.00% <100.00%> (+0.80%) 猬嗭笍
pkg/source/mtadapter/controller.go 0.00% <0.00%> (酶)
pkg/source/mtadapter/kafkasource.go 0.00% <0.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update fdf11c5...4f53abc. Read the comment docs.

@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-sandbox-eventing-kafka-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/source/adapter/adapter.go 55.4% 52.1% -3.3
pkg/source/adapter/message.go 77.1% 75.7% -1.5
pkg/source/mtadapter/adapter.go 49.5% 49.0% -0.5
pkg/source/reconciler/source/resources/receive_adapter.go 100.0% 89.5% -10.5

@knative-prow-robot
Copy link
Contributor

knative-prow-robot commented Aug 19, 2021

@lionelvillard: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
pull-knative-sandbox-eventing-kafka-go-coverage 4f53abc link /test pull-knative-sandbox-eventing-kafka-go-coverage

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lionelvillard
Copy link
Contributor Author

/assign @matzew

@lionelvillard
Copy link
Contributor Author

@matzew do you have time to TAL at this one?

@lionelvillard
Copy link
Contributor Author

gentle ping.

@lionelvillard
Copy link
Contributor Author

should I reassign to someone else @matzew ?


type extensionAsTransformer map[string]string

func (c extensionAsTransformer) Transform(r binding.MessageMetadataReader, w binding.MessageMetadataWriter) error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would this be useful outside?

Copy link
Contributor

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lionelvillard, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 21cca66 into knative-extensions:main Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a mean on kafka CR event source creation to specify Ce-overrides to be sent with the event.
4 participants