Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #320 #325

Merged
merged 1 commit into from Jun 2, 2021
Merged

Conversation

vaikas
Copy link
Contributor

@vaikas vaikas commented Jun 1, 2021

Fixes #320

  • 馃悰 Fix incorrect link to both nightly / to-be-released standalone broker.

/kind

Fixes #

Release Note

Fix #320

Docs


@knative-prow-robot
Copy link

@vaikas: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Fixes #320

  • 馃悰 Fix incorrect link to both nightly / to-be-released standalone broker.

/kind

Fixes #

Release Note

Fix #320

Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 1, 2021
@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 1, 2021
@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

Merging #325 (4c257e3) into main (c3aa10c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #325   +/-   ##
=======================================
  Coverage   78.38%   78.38%           
=======================================
  Files          42       42           
  Lines        2475     2475           
=======================================
  Hits         1940     1940           
  Misses        412      412           
  Partials      123      123           

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update c3aa10c...4c257e3. Read the comment docs.

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 2, 2021
@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott, vaikas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 2c1f4be into knative-extensions:main Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nightly version for standalone broker returns 404
3 participants