Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small things #572

Merged
merged 7 commits into from Jan 20, 2022
Merged

Small things #572

merged 7 commits into from Jan 20, 2022

Conversation

ChunyiLyu
Copy link
Contributor

Changes

  • 🧹 Small code style refactors that I noticed while looking at the repo, commit messages should be self explanatory. Unit tests are all passing locally. Could not get conformance tests to run sadly :/

/kind cleanup

Release Note

Small code refactors

Docs

@knative-prow-robot knative-prow-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 17, 2022
@knative-prow-robot
Copy link

Welcome @ChunyiLyu! It looks like this is your first PR to knative-sandbox/eventing-rabbitmq 🎉

@gabo1208
Copy link
Contributor

What errors are you facing when trying to run conformance tests locally?

@knative-prow-robot knative-prow-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jan 17, 2022
embano1
embano1 approved these changes Jan 17, 2022
View reviewed changes
Copy link
Contributor

@embano1 embano1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkg/reconciler/testing/factory.go
@@ -91,7 +91,7 @@ func MakeFactory(ctor Ctor, unstructured bool, logger *zap.SugaredLogger) Factor
ctx = controller.WithEventRecorder(ctx, eventRecorder)

// Configure the ConfigMap static watcher
configMaps := []*corev1.ConfigMap{}
var configMaps []*corev1.ConfigMap
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@knative-prow-robot
Copy link

@embano1: changing LGTM is restricted to collaborators

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ChunyiLyu
Copy link
Contributor Author

@gabo1208

Yes I tried make test-conformance locally this is the error I kept on getting:

BROKER_TEMPLATES=/Users/clyu/workspace/eventing-rabbitmq/test/conformance/testdata/with-operator \
	BROKER_CLASS=RabbitMQBroker \
	go test -v -tags=e2e \
		-count=1 -parallel=12 -timeout=20m \
		-run TestBrokerConformance /Users/clyu/workspace/eventing-rabbitmq/test/conformance/...
{"level":"info","ts":1642430963.129856,"logger":"fallback","caller":"injection/injection.go:61","msg":"Starting informers..."}
level All, state Any, feature

=== RUN   TestBrokerConformance
2022/01/17 14:49:24 Using base gcr.io/distroless/static:nonroot for knative.dev/reconciler-test/cmd/eventshub
2022/01/17 14:49:26 Building knative.dev/reconciler-test/cmd/eventshub for linux/amd64
2022/01/17 14:49:30 Loading kind.local/eventshub:7f87812e19d9044cf261237a73736c08b5d8a2b297018aa77d5250786042f734
Error: failed to publish images: error publishing ko://knative.dev/reconciler-test/cmd/eventshub: no nodes found for cluster "kind"
2022/01/17 14:49:30 error during command execution:failed to publish images: error publishing ko://knative.dev/reconciler-test/cmd/eventshub: no nodes found for cluster "kind"
error attempting to ko publish: exit status 1
--- FAIL: TestBrokerConformance (7.73s)
panic: exit status 1 [recovered]
	panic: exit status 1

I do have a local kind cluster created and targeted. Is there some other setup that I missed?

@gabo1208
Copy link
Contributor

gabo1208 commented Jan 18, 2022 •
edited

How is your local cluster called? If it is not called kind try settting the KIND_CLUSTER_NAME VARIABLE to the cluster's name

@ChunyiLyu
Copy link
Contributor Author

@gabo1208 Yes my kind cluster is called kind. I set KIND_CLUSTER_NAME_VARIABLE to kind just in case, but it's the same failure.

@codecov
Copy link

codecov bot commented Jan 18, 2022 •
edited

Codecov Report

Merging #572 (0e5db67) into main (0506257) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #572   +/-   ##
=======================================
  Coverage   75.50%   75.50%           
=======================================
  Files          47       47           
  Lines        2870     2870           
=======================================
  Hits         2167     2167           
  Misses        565      565           
  Partials      138      138
Impacted Files Coverage Δ
pkg/apis/duck/v1beta1/rabbit.go 0.00% <ø> (ø)
pkg/reconciler/broker/broker_test_helper.go 80.00% <ø> (ø)
pkg/reconciler/broker/resources/ingress.go 97.22% <ø> (ø)
.../reconciler/brokerstandalone/broker_test_helper.go 72.72% <ø> (ø)
...g/reconciler/brokerstandalone/resources/ingress.go 97.22% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0506257...0e5db67. Read the comment docs.

@benmoss
Copy link
Contributor

benmoss commented Jan 20, 2022

@gabo1208 Yes my kind cluster is called kind. I set KIND_CLUSTER_NAME_VARIABLE to kind just in case, but it's the same failure.

No, he meant KIND_CLUSTER_NAME. An unfortunate choice in the Makefile is that it sets that variable if it's not set, so rather than defaulting to kind it defaults to eventing-rabbitmq-e2e.

@ChunyiLyu
Copy link
Contributor Author

@benmoss I can run conformance tests and e2e tests locally now and they are all passing after running necessary make commands. What should we do with this PR? Would it be fine to merge it now or should we wait til this is fixed: #577

@benmoss
Copy link
Contributor

benmoss commented Jan 20, 2022

I'd ask @gabo1208

@benmoss
Copy link
Contributor

benmoss commented Jan 20, 2022

/approve
/lgtm

@knative-prow-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benmoss, ChunyiLyu, embano1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 20, 2022
@knative-prow-robot knative-prow-robot merged commit c5ab68d into knative-extensions:main Jan 20, 2022
@ChunyiLyu ChunyiLyu deleted the small-things branch January 20, 2022 15:57
@ChunyiLyu ChunyiLyu restored the small-things branch January 20, 2022 15:57
@ChunyiLyu ChunyiLyu deleted the small-things branch April 1, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@embano1 embano1 embano1 approved these changes

Assignees

@benmoss benmoss

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ChunyiLyu @knative-prow-robot @gabo1208 @benmoss @embano1