Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes standalone broker #708

Merged
merged 3 commits into from Apr 12, 2022

Conversation

gab-satchi
Copy link
Contributor

Changes

  • 🗑️ removes deprecated standalone broker
  • removes controller, CRDs and reconcilers
  • removes relevant make targets
  • removes relevant GitHub actions

Since it's a large PR, will send out doc changes in a follow-up PR

/kind removal

Fixes #627

Release Note

- Remove support for managed RabbitMQ brokers

@knative-prow knative-prow bot added kind/removal Categorizes issue or PR as related to removing dead code, or deprecated apis/features. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 11, 2022
- removes controller, CRDs and reconcilers
- removes relevant make targets
- removes relevant GitHub actions
@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #708 (9516a6a) into main (a93b956) will increase coverage by 0.23%.
The diff coverage is 76.92%.

@@            Coverage Diff             @@
##             main     #708      +/-   ##
==========================================
+ Coverage   75.08%   75.31%   +0.23%     
==========================================
  Files          47       31      -16     
  Lines        2910     2346     -564     
==========================================
- Hits         2185     1767     -418     
+ Misses        585      515      -70     
+ Partials      140       64      -76     
Impacted Files Coverage Δ
pkg/apis/sources/v1alpha1/rabbitmq_defaults.go 0.00% <0.00%> (ø)
pkg/apis/sources/v1alpha1/rabbitmq_types.go 50.00% <0.00%> (ø)
pkg/rabbit/service.go 0.00% <0.00%> (ø)
pkg/reconciler/broker/broker_test_helper.go 80.31% <ø> (+0.31%) ⬆️
pkg/reconciler/trigger/trigger.go 60.93% <41.26%> (+0.70%) ⬆️
pkg/adapter/adapter.go 58.50% <70.00%> (-8.49%) ⬇️
pkg/rabbit/label.go 93.75% <93.75%> (ø)
pkg/adapter/message.go 90.10% <100.00%> (-0.52%) ⬇️
pkg/apis/eventing/v1/trigger_validation.go 71.11% <100.00%> (-0.77%) ⬇️
pkg/apis/sources/v1alpha1/rabbitmq_validation.go 60.60% <100.00%> (-1.30%) ⬇️
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 002391d...9516a6a. Read the comment docs.

Copy link
Contributor

@ChunyiLyu ChunyiLyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2022
@knative-prow
Copy link

knative-prow bot commented Apr 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ChunyiLyu, gab-satchi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ChunyiLyu,gab-satchi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit d73f7f3 into knative-extensions:main Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/removal Categorizes issue or PR as related to removing dead code, or deprecated apis/features. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Support for managed broker
2 participants