Source params reordering with docs and samples updates #810

gabo1208 · 2022-06-10T18:19:51Z

Changes

🎁 Source's Spec RabbitMQ related parameters have been grouped in the RabbitMQResourcesConfig Spec
🎁 Source's Spec Delivery related parameters have been grouped in the Delivery Spec
🎁 Added support for ClusterReference ConnectionSecret option to the Source
🧹 Updating Source's docs and samples to reflect this changes

/kind api-change documentation

Fixes #

Release Note

- BREAKING: 🎁 Source's Spec RabbitMQ related parameters have been grouped in the RabbitMQResourcesConfig Spec, Source's Spec Delivery related parameters have been grouped in the Delivery Spec
- 🎁 Added support for ClusterReference ConnectionSecret option to the Source

gabo1208 · 2022-06-10T18:19:58Z

/hold

codecov · 2022-06-12T03:47:17Z

Codecov Report

Merging #810 (5c19442) into main (d3524e0) will decrease coverage by 0.56%.
The diff coverage is 63.15%.

@@            Coverage Diff             @@
##             main     #810      +/-   ##
==========================================
- Coverage   72.44%   71.88%   -0.57%     
==========================================
  Files          39       39              
  Lines        2577     2600      +23     
==========================================
+ Hits         1867     1869       +2     
- Misses        645      665      +20     
- Partials       65       66       +1

Impacted Files	Coverage Δ
pkg/apis/eventing/v1alpha1/rabbitmq_defaults.go	`0.00% <0.00%> (ø)`
pkg/apis/sources/v1alpha1/rabbitmq_defaults.go	`0.00% <0.00%> (ø)`
pkg/apis/sources/v1alpha1/rabbitmq_types.go	`50.00% <ø> (ø)`
pkg/rabbit/service.go	`8.71% <0.00%> (-0.89%)`	⬇️
pkg/reconciler/source/resources/receive_adapter.go	`95.41% <81.81%> (+0.03%)`	⬆️
pkg/adapter/adapter.go	`58.75% <83.33%> (ø)`
pkg/apis/sources/v1alpha1/rabbitmq_validation.go	`84.09% <96.00%> (+12.35%)`	⬆️
pkg/rabbit/exchange.go	`100.00% <100.00%> (ø)`
pkg/rabbit/queue.go	`100.00% <100.00%> (ø)`
pkg/rabbit/message.go	`68.90% <0.00%> (-2.53%)`	⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3524e0...5c19442. Read the comment docs.

gabo1208 · 2022-06-14T19:11:08Z

/hold cancel

…oo, this includes a refactor to reuse some helper methods for the triggers, sources and brokers. Fixed some tests and docs but still some to go in other commits

… to fix the unit tests + fixed source new parameters description yaml in config dir recovered vhost for conformance tests

…ster references + added sources to secret generator added secret reconciliation to source added secret informer

…lete docs pr about the new source api will come next to this one

…bbitmqResourcesConfig specs, refactored queue type and fixed tests to go along with it, now the source also have queue type + updated codegen

… by seting the predeclared flag

…g the conenction secret + fixed sample, still some work to do on the docs

gab-satchi

just some minor things

pkg/adapter/adapter.go

pkg/apis/sources/v1alpha1/rabbitmq_validation.go

pkg/rabbit/service.go

pkg/apis/sources/v1alpha1/rabbitmq_validation.go

gab-satchi · 2022-06-15T15:09:05Z

another nit regarding the release notes: We can just have a single line or a few lines regarding the Source API changing. With a BREAKING: prefix. With the release notes in the last few PRs, they highlight individual things the PRs are doing and that's too detailed for release notes.

gab-satchi

some minor things

pkg/apis/eventing/v1alpha1/rabbitmq_defaults.go

pkg/apis/sources/v1alpha1/rabbitmq_defaults.go

pkg/apis/sources/v1alpha1/rabbitmq_validation.go

gab-satchi

/lgtm
/hold for tests

knative-prow · 2022-06-16T18:54:07Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gab-satchi, gabo1208

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [gab-satchi,gabo1208]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

gab-satchi · 2022-06-16T18:54:18Z

/hold cancel

knative-prow bot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/documentation labels Jun 10, 2022

gabo1208 force-pushed the source-params-reordering branch 3 times, most recently from 3207363 to 794a837 Compare June 12, 2022 03:32

gabo1208 force-pushed the source-params-reordering branch 6 times, most recently from 425d227 to f449139 Compare June 12, 2022 18:28

gabo1208 mentioned this pull request Jun 14, 2022

Support RabbitMQ's ConnectionSecret #819

Closed

3 tasks

knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 14, 2022

knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 14, 2022

gabo1208 added 10 commits June 14, 2022 14:12

removed deprecated params from docs and tests

c7c97c5

updated codegen and fixed import path

84eabac

fixing e2e and unit tests

4ba2fb7

added missing test cases

5cc5c8e

removed webhook files

9d91108

removed unnused params to implement cluster reference in the source t…

a80afd5

…oo, this includes a refactor to reuse some helper methods for the triggers, sources and brokers. Fixed some tests and docs but still some to go in other commits

fixed service client set reference when creating a new rabbit service…

0eb1769

… to fix the unit tests + fixed source new parameters description yaml in config dir recovered vhost for conformance tests

marking exchange ready when predeclared too

4f303b5

updated cluster role so the source now is capable to use rabbitmq clu…

13b9fe3

…ster references + added sources to secret generator added secret reconciliation to source added secret informer

fixed vhost example and some docs info regarding the source, the comp…

42fbbf4

…lete docs pr about the new source api will come next to this one

gabo1208 added 5 commits June 14, 2022 14:41

rearanged source spec parameters by groping them into delivery and ra…

01b6103

…bbitmqResourcesConfig specs, refactored queue type and fixed tests to go along with it, now the source also have queue type + updated codegen

fixed e2e tests and docs

c626c5c

removing queue spec from source since users can have their own config…

a6d48dc

… by seting the predeclared flag

added source capability to connect to external rabbitmq clusters usin…

9de811d

…g the conenction secret + fixed sample, still some work to do on the docs

fixed source's samples docs

e4611af

gabo1208 force-pushed the source-params-reordering branch from 652548d to e4611af Compare June 14, 2022 19:51

knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 14, 2022

knative-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 14, 2022

feature still not ready for the broker

334c8b7

gabo1208 mentioned this pull request Jun 14, 2022

Redesigning RabbitMQSource API #765

Closed

8 tasks

gab-satchi reviewed Jun 15, 2022

View reviewed changes

pkg/adapter/adapter.go Outdated Show resolved Hide resolved

pkg/apis/sources/v1alpha1/rabbitmq_validation.go Show resolved Hide resolved

pkg/rabbit/service.go Outdated Show resolved Hide resolved

gab-satchi reviewed Jun 15, 2022

View reviewed changes

pkg/apis/sources/v1alpha1/rabbitmq_validation.go Outdated Show resolved Hide resolved

gabo1208 added 3 commits June 15, 2022 12:08

addresed pr comments

27f6f3f

removing namespace from rabbitmqurl function

adecc00

fixed env names

42dcb2c

gabo1208 requested a review from gab-satchi June 15, 2022 19:50

gab-satchi reviewed Jun 16, 2022

View reviewed changes

solved rabbitmq validation and default pr comments

35a8ccb

gabo1208 requested a review from gab-satchi June 16, 2022 15:34

fixed source

5c19442

gab-satchi approved these changes Jun 16, 2022

View reviewed changes

knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 16, 2022

knative-prow bot assigned gab-satchi Jun 16, 2022

knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2022

knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 16, 2022

knative-prow bot merged commit 96a65a4 into knative-extensions:main Jun 16, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source params reordering with docs and samples updates #810

Source params reordering with docs and samples updates #810

gabo1208 commented Jun 10, 2022 •

edited

gabo1208 commented Jun 10, 2022

codecov bot commented Jun 12, 2022 •

edited

gabo1208 commented Jun 14, 2022

gab-satchi left a comment

gab-satchi commented Jun 15, 2022

gab-satchi left a comment

gab-satchi left a comment

knative-prow bot commented Jun 16, 2022

gab-satchi commented Jun 16, 2022

Source params reordering with docs and samples updates #810

Source params reordering with docs and samples updates #810

Conversation

gabo1208 commented Jun 10, 2022 • edited

Changes

gabo1208 commented Jun 10, 2022

codecov bot commented Jun 12, 2022 • edited

Codecov Report

gabo1208 commented Jun 14, 2022

gab-satchi left a comment

Choose a reason for hiding this comment

gab-satchi commented Jun 15, 2022

gab-satchi left a comment

Choose a reason for hiding this comment

gab-satchi left a comment

Choose a reason for hiding this comment

knative-prow bot commented Jun 16, 2022

gab-satchi commented Jun 16, 2022

gabo1208 commented Jun 10, 2022 •

edited

codecov bot commented Jun 12, 2022 •

edited