Skip to content
This repository has been archived by the owner on Apr 30, 2024. It is now read-only.

drop safe-to-evict annotations #540

Merged
merged 1 commit into from
May 31, 2023
Merged

drop safe-to-evict annotations #540

merged 1 commit into from
May 31, 2023

Conversation

dprotaso
Copy link
Contributor

@dprotaso dprotaso commented May 30, 2023 •
edited
Loading

@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 30, 2023
@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Merging #540 (c619774) into main (102581f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #540   +/-   ##
=======================================
  Coverage   83.96%   83.96%           
=======================================
  Files           5        5           
  Lines         368      368           
=======================================
  Hits          309      309           
  Misses         44       44           
  Partials       15       15

@dprotaso dprotaso mentioned this pull request May 30, 2023
Closed
ReToCode
ReToCode approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow
Copy link

knative-prow bot commented May 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 31, 2023
@knative-prow knative-prow bot merged commit 0458c44 into knative-extensions:main May 31, 2023
18 checks passed
@dprotaso dprotaso deleted the drop-safe-to-evict branch May 31, 2023 15:52
@dprotaso
Copy link
Contributor Author

dprotaso commented Jun 1, 2023

/cherry-pick release-1.10
/cherry-pick release-1.9

@knative-prow-robot knative-prow-robot mentioned this pull request Jun 1, 2023
Merged
@knative-prow-robot
Copy link

@dprotaso: new pull request created: #542

In response to this:

/cherry-pick release-1.10
/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dprotaso
Copy link
Contributor Author

dprotaso commented Jun 1, 2023

/cherry-pick release-1.9

@knative-prow-robot
Copy link

@dprotaso: new pull request created: #543

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot mentioned this pull request Jun 1, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ReToCode ReToCode ReToCode approved these changes

Assignees

@ReToCode ReToCode

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dprotaso @knative-prow-robot @ReToCode