Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Contour to version 1.29 #1091

Merged
merged 4 commits into from
May 23, 2024

Conversation

izabelacg
Copy link
Member

@izabelacg izabelacg commented May 15, 2024

Changes

  • 🎁 Bump Contour to version 1.29

/kind enhancement

Release Note

Update Contour version to v1.29.0

@knative-prow knative-prow bot requested review from KauzClay and ReToCode May 15, 2024 16:21
@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 15, 2024
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.92%. Comparing base (820cd7c) to head (974fa9d).
Report is 27 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1091      +/-   ##
==========================================
- Coverage   94.06%   93.92%   -0.14%     
==========================================
  Files          11       11              
  Lines         893      708     -185     
==========================================
- Hits          840      665     -175     
+ Misses         32       22      -10     
  Partials       21       21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dprotaso
Copy link
Contributor

/hold I want to rule out the failure in serving before we bump

knative/serving#15204

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 17, 2024
@dprotaso
Copy link
Contributor

/hold cancel
/lgtm
/approve

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 23, 2024
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 23, 2024
Copy link

knative-prow bot commented May 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, izabelacg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 23, 2024
@knative-prow knative-prow bot merged commit e99cca4 into knative-extensions:main May 23, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants