Avoid thundering herd of probes during failover. #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change guards the status prober with a simple readiness check as an optimization for the case of failing over and globally resyncing resources. When a fresh controller pod slurps through ~100 kingress for the first time we will currently probe ALL of them. On a 10 Node cluster, with 1 public and 3 private hostnames, this works out to a lot of probes: ``` 100 * (1 * 10 + 3 * 10) = 4000 ``` Factor in what we do with endpoint probing, and it adds roughly 2000 probes. Currently, this is what the scale-100 test in serving is doing every 30s or so, in addition to the standard work it is doing. Fixes: knative-extensions#203 Possibly related to: knative-extensions#226
knative-prow-robot
added
approved
|
Ok, this clearly has bugs. |
|
The following is the coverage report on the affected files.
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattmoor, n3wscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change guards the status prober with a simple readiness check as an
optimization for the case of failing over and globally resyncing resources.
When a fresh controller pod slurps through ~100 kingress for the first time
we will currently probe ALL of them. On a 10 Node cluster, with 1 public and
3 private hostnames, this works out to a lot of probes:
Factor in what we do with endpoint probing, and it adds roughly 2000 probes.
Currently, this is what the scale-100 test in serving is doing every 30s or so,
in addition to the standard work it is doing.
Fixes: #203
Possibly related to: #226