Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TestRetry conformance test #20

Open
nak3 opened this issue Mar 30, 2021 · 5 comments
Open

Add TestRetry conformance test #20

nak3 opened this issue Mar 30, 2021 · 5 comments
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Milestone
Icebox

Comments

@nak3
Copy link
Contributor

nak3 commented Mar 30, 2021 •
edited
Loading

This is a tracking issue for kubernetes-sigs/gateway-api#184.
Currently gateway-apis does not define the API of retry policy. So Istio attempts to retry 503 error which is an Istio's default behavior.

We need to wait for gateway-apis defines the API by kubernetes-sigs/gateway-api#184.
@howardjohn
Copy link

This is going to be pretty tricky for Istio for mesh traffic if the default is not the same as Istio, since we may end up with defaulting to 2 retries, but then if a user defines an HTTPRoute we suddenly switch to no retries.

@nak3 nak3 mentioned this issue Apr 1, 2021
Closed
5 tasks
@nak3 nak3 mentioned this issue Apr 19, 2021
Closed
8 tasks
@github-actions
Copy link
Contributor

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 29, 2021
@nak3 nak3 removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 13, 2021
@nak3
Copy link
Contributor Author

nak3 commented Jul 23, 2021

xref: https://gateway-api.sigs.k8s.io/geps/gep-713/

@nak3 nak3 mentioned this issue Oct 11, 2021
Merged
@github-actions
Copy link
Contributor

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 22, 2021
@nak3 nak3 removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 15, 2021
@nak3 nak3 added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Nov 29, 2021
@nak3 nak3 added this to the Icebox milestone Feb 21, 2022
This was referenced Aug 8, 2022
Closed
Closed
@carlisia carlisia changed the title Add TestRetry test Add TestRetry conformance test Aug 8, 2022
@dprotaso
Copy link
Contributor

dprotaso commented Nov 24, 2022 •
edited
Loading

From: kubernetes-sigs/gateway-api#184 (comment)

Retries will be controlled by a implementation (ie. istio/contour) specific policy (kubernetes-sigs/gateway-api#713) that attaches to the gateway (or whatever).

Details here: https://gateway-api.sigs.k8s.io/references/policy-attachment

Thus we won't be able to configure using the GatewayAPI - so we'll still want a test to ensure there are no retries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Milestone
Icebox
Development

No branches or pull requests
3 participants
@dprotaso @howardjohn @nak3