Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle more than about 64 TLS Knative Routes #317

Open
evankanderson opened this issue Jun 28, 2022 · 9 comments
Open

Handle more than about 64 TLS Knative Routes #317

evankanderson opened this issue Jun 28, 2022 · 9 comments
Labels
triage/accepted Issues which should be fixed (post-triage)

Comments

@evankanderson
Copy link
Contributor

evankanderson commented Jun 28, 2022

(update from @dprotaso) See this comment for the current limit: #317 (comment)

We add a Listener (and a certificate reference) per Knative Route (KIngress). Each one is around 300 bytes, which means that we can probably fit around 3000 Routes into one Gateway before we exceed etcd storage limits.

According to some of the gateway maintainers, we should be able to split these across multilpe Gateways that all share the same IP address (so that users can still get that nice wildcard DNS mapping).

This issue tracks packing Listeners into multiple Gateways, it's extracted from[ this PR comment

@youngnick
Copy link

Wearing my Gateway API maintainer hat, it's absolutely intended that implementations may merge Gateways together into a single data plane config, but we don't mandate it. So the sort of sharding you're describing is definitely possible.

The exact details of how it will work may vary with the underlying data path implementation though.

@dprotaso
Copy link
Contributor

dprotaso commented Jun 30, 2022

Interestingly enough we've seen Routes take longer to become 'Ready=True` as the number of increases. The root cause seems to be the underlying ingress implementation

ie. see contour HTTProxy's timings: projectcontour/contour#4058

I don't think we've done similar tests with TLS routes where gateways & listeners increase

@github-actions
Copy link
Contributor

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 29, 2022
@knative-prow-robot
Copy link
Contributor

This issue or pull request is stale because it has been open for 90 days with no activity.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close

/lifecycle stale

@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 30, 2022
@github-actions
Copy link
Contributor

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 29, 2023
@ReToCode
Copy link
Member

/remove-lifecycle stale

@knative-prow knative-prow bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 30, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2023

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 1, 2023
@ReToCode
Copy link
Member

ReToCode commented May 1, 2023

/remove-lifecycle stale

@knative-prow knative-prow bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 1, 2023
@ReToCode ReToCode added the triage/accepted Issues which should be fixed (post-triage) label May 1, 2023
@dprotaso
Copy link
Contributor

dprotaso commented Apr 2, 2024

I've created a GEP issue to help address this - kubernetes-sigs/gateway-api#1713

Note the Gateway API folks have a limit on the # of listeners per Gateway and it's 64

@dprotaso dprotaso changed the title Handle more than about 3000 TLS Knative route Handle more than about 64 TLS Knative Routes Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage/accepted Issues which should be fixed (post-triage)
Projects
None yet
Development

No branches or pull requests

5 participants