Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRY test scripts + improve documentation #323

Closed
wants to merge 2 commits into from

Conversation

carlisia
Copy link
Member

@carlisia carlisia commented Jul 1, 2022

Closes #322.
Closes #292.

Thinking along the lines on how to refactor and organize for having tests for multiple vendors. This is only a start.

TODOs:

  • refactor contour setup code into its own script (like istio.sh
  • test if some sourcing of scripts might not be needed, if so remove
  • DRY e2e and conformance GH workflows to point at test scripts (w/o doing the setup that is already in the scripts)
  • clean up the conformance test scripts
  • test testing instructions in the DEVELOPMENT.md
  • test installation instructions in the README.md

Changes

/kind

Fixes #

Release Note


Docs


@knative-prow
Copy link

knative-prow bot commented Jul 1, 2022

@carlisia: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Closes #322.
Closes #292.

Thinking along the lines on how to refactor and organize for having tests for multiple vendors. This is only a start.

Changes

/kind

Fixes #

Release Note


Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow
Copy link

knative-prow bot commented Jul 1, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 1, 2022
@knative-prow
Copy link

knative-prow bot commented Jul 1, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carlisia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 1, 2022
@carlisia
Copy link
Member Author

carlisia commented Jul 1, 2022

/assign @dprotaso @nak3
c/c @evankanderson

Would love to get an idea if this is a good direction if anyone has a chance, thank you!

@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #323 (041440f) into main (a15b90b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #323   +/-   ##
=======================================
  Coverage   12.91%   12.91%           
=======================================
  Files          20       20           
  Lines        2958     2958           
=======================================
  Hits          382      382           
  Misses       2554     2554           
  Partials       22       22           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a15b90b...041440f. Read the comment docs.

Closes knative-extensions#322.
Closes knative-extensions#292.

Think along the lines on how to refactor and organize for having tests for multiple vendors. This is only a start.
@carlisia
Copy link
Member Author

carlisia commented Jul 3, 2022

Closing this for now.

@carlisia carlisia closed this Jul 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor test scripts to run 1+n e2e tests with the prow automation Improve installation documentation
3 participants