Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop non-KIngress Conformance Tests #424

Merged

Conversation

dprotaso
Copy link
Contributor

@dprotaso dprotaso commented Dec 5, 2022

Description

Having these tests (using the gateway api directly) isn't necessary since we already have our KIngress tests which are ensuring we have the correct functionality. Plus it's a source of confusion

Changes

  • Drop conformance tests that uses the gateway api directly
  • drop issue template
  • Update README.md

Closes

@knative-prow
Copy link

knative-prow bot commented Dec 5, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 5, 2022
@dprotaso
Copy link
Contributor Author

dprotaso commented Dec 5, 2022

/assign @nak3

@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Merging #424 (707aec3) into main (94c2bd2) will increase coverage by 56.31%.
The diff coverage is n/a.

❗ Current head 707aec3 differs from pull request most recent head 1f0de7b. Consider uploading reports for the commit 1f0de7b to get more accurate results

@@             Coverage Diff             @@
##             main     #424       +/-   ##
===========================================
+ Coverage   16.45%   72.76%   +56.31%     
===========================================
  Files          21        9       -12     
  Lines        3167      683     -2484     
===========================================
- Hits          521      497       -24     
+ Misses       2615      157     -2458     
+ Partials       31       29        -2     

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nak3
Copy link
Contributor

nak3 commented Dec 6, 2022

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2022
@knative-prow knative-prow bot merged commit 860e9e1 into knative-extensions:main Dec 6, 2022
@dprotaso dprotaso deleted the drop-gateway-conformance branch December 6, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
2 participants