Opinionated knative gateway conformance #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
do-not-merge/hold
knative-prow
bot
added
approved
|
/hold cancel |
knative-prow
bot
removed
the
do-not-merge/hold
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #673 +/- ##
===========================================
+ Coverage 66.93% 78.11% +11.18%
===========================================
Files 15 16 +1
Lines 862 1106 +244
===========================================
+ Hits 577 864 +287
+ Misses 254 203 -51
- Partials 31 39 +8 ☔ View full report in Codecov by Sentry. |
|
/retest |
|
/test all |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
dprotaso
force-pushed
the
opinionated-gateway-test
branch
from
457bd9d
to
396e629
Compare
dprotaso
changed the title
knative-prow
bot
removed
the
do-not-merge/work-in-progress
|
/assign @izabelacg |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #621
This runs the Gateway conformance tests along side our Knative ones testing the features that we require.
If the Gateway Conformance tests fail then we do not fail the test - it's informational