Skip to content

Commit

Permalink
Fix more lint warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
@ReToCode
ReToCode committed Apr 18, 2023
1 parent d8164e8 commit 13c76e4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/generate-upstream-cert.sh
View file
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ openssl req -out "${out_dir}"/tls.csr -newkey rsa:2048 -nodes -keyout "${out_dir
openssl x509 -req -extfile <(printf "subjectAltName=DNS:%s" "$san") -days 365 -in "${out_dir}"/tls.csr -CA "${out_dir}"/root.crt -CAkey "${out_dir}"/root.key -CAcreateserial -out "${out_dir}"/tls.crt

# Override certificate in istio-system namespace with the generated CA
# Delete it first, otherwise istio reconciliation does not work propperly
# Delete it first, otherwise istio reconciliation does not work properly
kubectl delete -n ${ISTIO_NAMESPACE} secret knative-serving-certs
kubectl create -n ${ISTIO_NAMESPACE} secret generic knative-serving-certs \
--from-file=ca.crt="${out_dir}"/root.crt \

Check warning on line 38 in test/generate-upstream-cert.sh

View workflow job for this annotation

GitHub Actions / style / suggester / shell 

[shfmt] reported by reviewdog 🐶


Raw Output:
test/generate-upstream-cert.sh:38:-    --from-file=ca.crt="${out_dir}"/root.crt \
test/generate-upstream-cert.sh:39:-    --dry-run=client -o yaml |  \
test/generate-upstream-cert.sh:40:-    sed  '/^metadata:/a\ \ labels: {"networking.internal.knative.dev/certificate-uid":"test-id"}' | kubectl apply -f -
test/generate-upstream-cert.sh:38:+  --from-file=ca.crt="${out_dir}"/root.crt \
test/generate-upstream-cert.sh:39:+  --dry-run=client -o yaml |
test/generate-upstream-cert.sh:40:+  sed '/^metadata:/a\ \ labels: {"networking.internal.knative.dev/certificate-uid":"test-id"}' | kubectl apply -f -
Expand Down

0 comments on commit 13c76e4

Please sign in to comment.