Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump kind version #1111

Merged
merged 2 commits into from
May 23, 2023
Merged

Bump kind version #1111

merged 2 commits into from
May 23, 2023

Conversation

pradnyavmw
Copy link
Contributor

Changes

  • Update version in kind-e2e.yaml

/kind

Fixes #

Release Note


Docs


@knative-prow
Copy link

knative-prow bot commented May 23, 2023

@pradnyavmw: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

  • Update version in kind-e2e.yaml

/kind

Fixes #

Release Note


Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 23, 2023
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Merging #1111 (b4fff31) into main (5270b82) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1111   +/-   ##
=======================================
  Coverage   81.84%   81.84%           
=======================================
  Files          18       18           
  Lines        1652     1652           
=======================================
  Hits         1352     1352           
  Misses        216      216           
  Partials       84       84           

@pradnyavmw
Copy link
Contributor Author

/retest

@dprotaso
Copy link
Contributor

/retest

Failures are due to #938

@@ -20,8 +20,8 @@ jobs:
fail-fast: false # Keep running if one leg fails.
matrix:
k8s-version:
- v1.25.x
Copy link
Contributor

@dprotaso dprotaso May 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should leave v1.25.x

@dprotaso
Copy link
Contributor

weird go mod error

../../../pkg/mod/golang.org/x/net@v0.0.0-20220127200216-cd36cc0744dd/idna/idna10.0.0.go:26:2: golang.org/x/text@v0.3.8: read "https:/proxy.golang.org/@v/v0.3.8.zip": stream error: stream ID 77; INTERNAL_ERROR; received from peer

/retest

@dprotaso
Copy link
Contributor

/lgtm
/approve

/retest

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 23, 2023
@knative-prow
Copy link

knative-prow bot commented May 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, pradnyavmw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dprotaso,pradnyavmw]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dprotaso
Copy link
Contributor

/retest

@dprotaso
Copy link
Contributor

dprotaso commented May 23, 2023

We should probably turn off these tests becaus we know they're flakey

(edit) made a PR #1112

@knative-prow knative-prow bot merged commit d7abe53 into knative-extensions:main May 23, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants