Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow unknown fields in VirtualService and Gateway deserialization #114

Merged
merged 1 commit into from
May 27, 2020
Merged

Allow unknown fields in VirtualService and Gateway deserialization #114

merged 1 commit into from
May 27, 2020

Conversation

tcnghia
Copy link
Contributor

@tcnghia tcnghia commented May 27, 2020

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label May 27, 2020
@knative-prow-robot knative-prow-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 27, 2020
@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2020
@tcnghia
Copy link
Contributor Author

tcnghia commented May 27, 2020

We can't add a e2e test here for the code change, since we our Istio installation has the Istio webhook (to detect bad-writes from our own code).

@tcnghia tcnghia changed the title Allow unknown fields. Allow unknown fields in VirtualService and Gateway deserialization May 27, 2020
@tcnghia
Copy link
Contributor Author

tcnghia commented May 27, 2020

/assign @ZhiminXiang

@vagababov
Copy link
Contributor

/lgtm
/retest

@ZhiminXiang
Copy link

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tcnghia, ZhiminXiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ZhiminXiang,tcnghia]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 2fc8c41 into knative-extensions:master May 27, 2020
@knative-prow-robot
Copy link
Contributor

@tcnghia: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-knative-net-istio-latest 4fd598e link /test pull-knative-net-istio-latest

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

tcnghia pushed a commit to tcnghia/net-istio that referenced this pull request May 28, 2020
Allow unknown fields. (knative-extensions#114)
49712c4
knative-prow-robot pushed a commit that referenced this pull request May 28, 2020
Allow unknown fields. (#114) (#120)
6d4a8eb
@tcnghia tcnghia mentioned this pull request Jul 14, 2020
Closed
@ReToCode ReToCode mentioned this pull request Mar 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evankanderson evankanderson Awaiting requested review from evankanderson

@markusthoemmes markusthoemmes Awaiting requested review from markusthoemmes

Assignees

@vagababov vagababov

@ZhiminXiang ZhiminXiang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VirtualService parsing: unknown field error causing old ksvc revision to stay deployed
5 participants
@tcnghia @vagababov @ZhiminXiang @knative-prow-robot @googlebot