Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ko label filter instead of removing KnativeCertificate yaml #1224

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

ReToCode
Copy link
Member

@ReToCode ReToCode commented Dec 7, 2023

Changes

/assign @skonto

Copy link

knative-prow bot commented Dec 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2023
@knative-prow knative-prow bot requested review from cardil and krsna-m December 7, 2023 13:11
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 7, 2023
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e6e6cb7) 81.66% compared to head (239908d) 81.84%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1224      +/-   ##
==========================================
+ Coverage   81.66%   81.84%   +0.17%     
==========================================
  Files          19       19              
  Lines        1680     1680              
==========================================
+ Hits         1372     1375       +3     
+ Misses        220      218       -2     
+ Partials       88       87       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@skonto
Copy link
Contributor

skonto commented Dec 7, 2023

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2023
@ReToCode
Copy link
Member Author

ReToCode commented Dec 7, 2023

/test integration-tests

@knative-prow knative-prow bot merged commit 6899886 into knative-extensions:main Dec 7, 2023
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants