Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop custom header for readiness and liveness probe #1292

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

izabelacg
Copy link
Member

@izabelacg izabelacg commented Mar 26, 2024

Changes

  • drop custom header k-kubelet-probe for readiness and liveness probe

Part of knative/serving#14981

@knative-prow knative-prow bot requested review from ReToCode and skonto March 26, 2024 21:38
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 26, 2024
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.66%. Comparing base (f57ffcf) to head (a831868).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1292      +/-   ##
==========================================
+ Coverage   80.51%   80.66%   +0.14%     
==========================================
  Files          26       26              
  Lines        2022     2022              
==========================================
+ Hits         1628     1631       +3     
+ Misses        301      299       -2     
+ Partials       93       92       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@izabelacg
Copy link
Member Author

/retest

@dprotaso
Copy link
Contributor

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 27, 2024
Copy link

knative-prow bot commented Mar 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, izabelacg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2024
@knative-prow knative-prow bot merged commit 39389b7 into knative-extensions:main Mar 27, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants