Gracefully drain connections when stopping the gateway #1855
norbjdknative-style.yaml
on: pull_request
style
/
changes
2s
style
/
...
/
Auto-format and Check
17s
style
/
...
/
Lint
27s
style
/
...
/
Do Not Submit
7s
style
/
...
/
shell
6s
style
/
...
/
yaml
21s
style
/
...
/
github_actions
0s
Matrix: style / Golang / Boilerplate Check
Annotations
7 errors and 6 warnings
|
style / Golang / Auto-format and Check:
test/gracefulshutdown/gracefulshutdown_test.go#L1
Please run goimports.
diff --git a/test/gracefulshutdown/gracefulshutdown_test.go b/test/gracefulshutdown/gracefulshutdown_test.go
index 94307ec..647d9e3 100644
--- a/test/gracefulshutdown/gracefulshutdown_test.go
+++ b/test/gracefulshutdown/gracefulshutdown_test.go
@@ -68,7 +68,7 @@ func TestGracefulShutdown(t *testing.T) {
clients := test.Setup(t)
ctx := context.Background()
-
+
// Create a service and an ingress
name, port, _ := ingress.CreateTimeoutService(ctx, t, clients)
_, client, _ := ingress.CreateIngressReady(ctx, t, clients, v1alpha1.IngressSpec{
|
|
style / Golang / Auto-format and Check
Process completed with exit code 1.
|
|
style / Golang / Lint:
test/gracefulshutdown/gracefulshutdown_test.go#L1
: # knative.dev/net-kourier/test/gracefulshutdown [knative.dev/net-kourier/test/gracefulshutdown.test]
|
|
style / Golang / Lint:
test/gracefulshutdown/gracefulshutdown_test.go#L127
assignment mismatch: 2 variables but clients.KubeClient.CoreV1().Pods(gatewayNs).Delete returns 1 value
|
|
style / Golang / Lint:
test/gracefulshutdown/gracefulshutdown_test.go#L127
not enough arguments in call to clients.KubeClient.CoreV1().Pods(gatewayNs).Delete
|
|
style / Golang / Lint:
test/gracefulshutdown/gracefulshutdown_test.go#L128
unknown field LabelSelector in struct literal of type "k8s.io/apimachinery/pkg/apis/meta/v1".DeleteOptions (typecheck)
|
|
style / Golang / Lint
issues found
|
|
style / suggester / shell
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
style / Golang / Boilerplate Check (go)
Restore cache failed: Dependencies file is not found in /home/runner/work/net-kourier/net-kourier. Supported file pattern: go.sum
|
|
style / Golang / Boilerplate Check (sh)
Restore cache failed: Dependencies file is not found in /home/runner/work/net-kourier/net-kourier. Supported file pattern: go.sum
|
|
style / Golang / Auto-format and Check
Restore cache failed: Dependencies file is not found in /home/runner/work/net-kourier/net-kourier. Supported file pattern: go.sum
|
|
style / suggester / yaml
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
style / Golang / Lint
Restore cache failed: Dependencies file is not found in /home/runner/work/net-kourier/net-kourier. Supported file pattern: go.sum
|