Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Upgrade to latest dependencies #1211

Conversation

knative-automation
Copy link
Contributor

@knative-automation knative-automation commented Feb 21, 2024

drop toolchain directive -dprotaso

/cc knative-extensions/serving-writers
/assign knative-extensions/serving-writers

Produced by: knative-extensions/knobots/actions/update-deps

@knative-prow knative-prow bot requested a review from a team February 21, 2024 01:52
@knative-prow knative-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 21, 2024
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (656a0c6) 80.98% compared to head (f733094) 80.98%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1211   +/-   ##
=======================================
  Coverage   80.98%   80.98%           
=======================================
  Files          18       18           
  Lines        1499     1499           
=======================================
  Hits         1214     1214           
  Misses        223      223           
  Partials       62       62           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ReToCode
Copy link
Member

needs knative/pkg#2966

go.mod Outdated
go 1.18
go 1.21

toolchain go1.21.7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 21, 2024
Signed-off-by: Knative Automation <automation@knative.team>
@dprotaso
Copy link
Contributor

/lgtm
/approve

blocked on #1212

once it merges in HEAD re-running the tests should pass and unblock the merge

@knative-prow knative-prow bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 21, 2024
@dprotaso
Copy link
Contributor

/hold cancel
/lgtm
/approve

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 21, 2024
@dprotaso
Copy link
Contributor

/retest

Copy link

knative-prow bot commented Feb 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, knative-automation

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 4558c13 into knative-extensions:main Feb 21, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants