Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump cluster version to 1.28 in e2e scripts #1213

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

izabelacg
Copy link
Member

Changes

  • specify cluster version to 1.28 in e2e test scripts

Fixes #1212

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 21, 2024
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (656a0c6) 80.98% compared to head (c06bf80) 80.98%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1213   +/-   ##
=======================================
  Coverage   80.98%   80.98%           
=======================================
  Files          18       18           
  Lines        1499     1499           
=======================================
  Hits         1214     1214           
  Misses        223      223           
  Partials       62       62           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

test/e2e-tests.sh Outdated Show resolved Hide resolved
@dprotaso
Copy link
Contributor

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2024
Copy link

knative-prow bot commented Feb 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, izabelacg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2024
@dprotaso
Copy link
Contributor

/override "e2e tests (v1.28.x, quay.io/maistra-dev/proxyv2-ubi8:2.4-latest, tls)"

Copy link

knative-prow bot commented Feb 21, 2024

@dprotaso: Overrode contexts on behalf of dprotaso: e2e tests (v1.28.x, quay.io/maistra-dev/proxyv2-ubi8:2.4-latest, tls)

In response to this:

/override "e2e tests (v1.28.x, quay.io/maistra-dev/proxyv2-ubi8:2.4-latest, tls)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot merged commit c1e3db5 into knative-extensions:main Feb 21, 2024
38 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump e2e testing to use 1.28 clusters
2 participants