Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a hpa and pdb for kourier-gateway #990

Merged
merged 2 commits into from
Feb 8, 2023

Conversation

ReToCode
Copy link
Member

@ReToCode ReToCode commented Feb 7, 2023

Changes

  • Adds a PodDistruptionBudget and HorizontalPodAutoscaler to 3scale-kourier-gateway

/kind enhancement

Fixes #989

Release Note

A PodDistruptionBudget and a HorizontalPodAutoscaler were added for the 3scale-kourier-gateway deployment

@ReToCode
Copy link
Member Author

ReToCode commented Feb 7, 2023

/cc @nak3

@knative-prow knative-prow bot requested a review from nak3 February 7, 2023 12:50
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 7, 2023
@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Merging #990 (8c85d54) into main (9fb56e5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #990   +/-   ##
=======================================
  Coverage   80.77%   80.77%           
=======================================
  Files          18       18           
  Lines        1342     1342           
=======================================
  Hits         1084     1084           
  Misses        205      205           
  Partials       53       53           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nak3
Copy link
Contributor

nak3 commented Feb 8, 2023

It seems Code Style / style / Lint (pull_request) complains about missing new line. Is it possible to fix it? Otherwise, LGTM!

@ReToCode
Copy link
Member Author

ReToCode commented Feb 8, 2023

/test integration-tests

@nak3
Copy link
Contributor

nak3 commented Feb 8, 2023

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 8, 2023
@knative-prow
Copy link

knative-prow bot commented Feb 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2023
@knative-prow knative-prow bot merged commit 4806aab into knative-extensions:main Feb 8, 2023
@ReToCode ReToCode deleted the hpa-pdb branch February 8, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a PodDistruptionBudget and HorizontalPodAutoscaler to Kourier
2 participants