Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.14] Make the branch configurable for Serving #179

Conversation

houshengbo
Copy link
Contributor

No description provided.

Copy link

knative-prow bot commented May 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 17, 2024
Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-1.14@a37e5e5). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff               @@
##             release-1.14     #179   +/-   ##
===============================================
  Coverage                ?   48.83%           
===============================================
  Files                   ?       25           
  Lines                   ?     1894           
  Branches                ?        0           
===============================================
  Hits                    ?      925           
  Misses                  ?      924           
  Partials                ?       45           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-prow knative-prow bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 17, 2024
@houshengbo houshengbo force-pushed the release-1.14-configure branch 2 times, most recently from c8a8bd6 to c39885b Compare May 17, 2024 14:08
@houshengbo houshengbo closed this May 17, 2024
@houshengbo houshengbo reopened this May 17, 2024
@houshengbo houshengbo force-pushed the release-1.14-configure branch 4 times, most recently from f7c63ed to d68f866 Compare May 17, 2024 20:46
@houshengbo houshengbo added the lgtm Indicates that a PR is ready to be merged. label May 17, 2024
@knative-prow knative-prow bot merged commit 84cf476 into knative-extensions:release-1.14 May 17, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant