Resolved Trigger deadLetterSink is available in the status

[pierDipi]

Fixes #1086

Proposed Changes

• Resolved Trigger deadLetterSink is available in the status
• Upgrade eventing by running go get -u knative.dev/eventing@main && ./hack/update-deps.sh

Release Note

The Trigger status contains the resolved URL of the configured dead letter sink.

/kind enhancement

[codecov]

Codecov Report

Merging #1092 (d2e2f32) into main (ec19976) will decrease coverage by 0.01%.
The diff coverage is 91.42%.

@@             Coverage Diff              @@
##               main    #1092      +/-   ##
============================================
- Coverage     75.79%   75.77%   -0.02%     
+ Complexity      464      462       -2     
============================================
  Files            87       87              
  Lines          3003     3030      +27     
  Branches        138      138              
============================================
+ Hits           2276     2296      +20     
- Misses          561      568       +7     
  Partials        166      166              

Flag	Coverage Δ
java-unittests	79.89% <ø> (-0.31%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
control-plane/pkg/reconciler/trigger/trigger.go	70.62% <62.50%> (-1.21%)	⬇️
control-plane/pkg/core/config/utils.go	81.33% <100.00%> (+6.33%)	⬆️
...-plane/pkg/reconciler/trigger/trigger_lifecycle.go	42.85% <100.00%> (+8.16%)	⬆️
...a/broker/dispatcher/impl/RecordDispatcherImpl.java	82.35% <0.00%> (-10.59%)	⬇️
...e/eventing/kafka/broker/core/file/FileWatcher.java	78.20% <0.00%> (+5.12%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec19976...d2e2f32. Read the comment docs.

[matzew]

a bit of a nit here, see my comments.

Is it possible to also update/rebase this PR, inclduing the upgrade? So we can close 1088 when this is in?

[matzew]

@pierDipi or should we merge this, and just wait for the automated updater (fine with me too)

[pierDipi]

Yes, we can merge this, and wait for the bot to rebase #1088

[knative-metrics-robot]

The following is the coverage report on the affected files.
Say /test pull-knative-sandbox-eventing-kafka-broker-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
control-plane/pkg/core/config/utils.go	88.1%	91.1%	3.0
control-plane/pkg/reconciler/trigger/trigger.go	85.1%	84.6%	-0.5
control-plane/pkg/reconciler/trigger/trigger_lifecycle.go	41.2%	56.5%	15.3

[matzew]

/lgtm
/approve

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [matzew,pierDipi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[pierDipi]

Webhook EOF error
/retest

[pierDipi]

/retest