Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Kubernetes 1.19 and add 1.22 #1243

Merged
merged 2 commits into from
Sep 21, 2021
Merged

Drop Kubernetes 1.19 and add 1.22 #1243

merged 2 commits into from
Sep 21, 2021

Conversation

pierDipi
Copy link
Member

@pierDipi pierDipi commented Sep 15, 2021 •
edited

Proposed Changes

Release Note

Drop support for Kubernetes 1.19.

/kind removal
/assign @matzew

@knative-prow-robot knative-prow-robot added the kind/removal Categorizes issue or PR as related to removing dead code, or deprecated apis/features. label Sep 15, 2021
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 15, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added area/test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 15, 2021
@pierDipi
Copy link
Member Author

pierDipi commented Sep 15, 2021 •
edited

/hold let's see if k8s 1.22 works

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 15, 2021
@pierDipi pierDipi mentioned this pull request Sep 15, 2021
Merged
@codecov
Copy link

codecov bot commented Sep 15, 2021 •
edited

Codecov Report

Merging #1243 (1a712bd) into main (874b84f) will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1243      +/-   ##
============================================
- Coverage     75.84%   75.74%   -0.10%     
  Complexity      460      460              
============================================
  Files            87       87              
  Lines          3055     3055              
  Branches        136      136              
============================================
- Hits           2317     2314       -3     
- Misses          576      578       +2     
- Partials        162      163       +1
Flag Coverage Δ
java-unittests 80.04% <ø> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e/eventing/kafka/broker/core/file/FileWatcher.java 73.07% <0.00%> (-5.13%) ⬇️
...dispatcher/impl/consumer/BaseConsumerVerticle.java 92.85% <0.00%> (+3.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 874b84f...1a712bd. Read the comment docs.

@pierDipi
Copy link
Member Author

/retest

@pierDipi
Copy link
Member Author

Blocked by knative-extensions/knobots#108

@pierDipi
Update latest eventing and remove obsolete eventing versions
1a712bd 
Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
@knative-prow-robot knative-prow-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 15, 2021
@pierDipi
Copy link
Member Author

/retest

1 similar comment
@pierDipi
Copy link
Member Author

/retest

@pierDipi
Copy link
Member Author

/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 16, 2021
@pierDipi
Copy link
Member Author

This is the fix for #1240
/cc @ZhiminXiang

@ZhiminXiang
Copy link

/lgtm
/hold

Feel free to unhold it if anyone from eventing side feels it is good to go.

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 21, 2021
@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2021
@pierDipi
Copy link
Member Author

/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 21, 2021
@knative-prow-robot knative-prow-robot merged commit 3b860bf into knative-extensions:main Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZhiminXiang ZhiminXiang Awaiting requested review from ZhiminXiang

Assignees

@matzew matzew

@ZhiminXiang ZhiminXiang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cla: yes Indicates the PR's author has signed the CLA. kind/removal Categorizes issue or PR as related to removing dead code, or deprecated apis/features. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pierDipi @knative-prow-robot @ZhiminXiang @matzew