-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable KafkaSource controller #1339
Enable KafkaSource controller #1339
Conversation
/hold |
Codecov Report
@@ Coverage Diff @@
## main #1339 +/- ##
============================================
- Coverage 76.43% 76.19% -0.24%
+ Complexity 584 583 -1
============================================
Files 98 98
Lines 3632 3659 +27
Branches 166 166
============================================
+ Hits 2776 2788 +12
- Misses 643 656 +13
- Partials 213 215 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
939b961
to
5e5edda
Compare
/test pull-knative-sandbox-eventing-kafka-broker-integration-tests |
0a56246
to
a27adde
Compare
83ef424
to
9583121
Compare
e2a19f5
to
d317205
Compare
1262fe5
to
721b545
Compare
5c30a36
to
8efb3af
Compare
f2bb169
to
2630a87
Compare
2630a87
to
4ccaa7a
Compare
Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>
Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>
Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>
Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>
Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>
4ccaa7a
to
abf2890
Compare
/unhold |
4fa9b21
to
a97991b
Compare
Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>
a97991b
to
0010c4d
Compare
The following is the coverage report on the affected files.
|
/lgtm Thanks, looks great! We now have a KafkaSource impl! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aliok, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks for your reviews! |
Fixes #312
Proposed Changes
Release Note
Docs