Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unicode control characters in Strimzi operator YAML #1414

Merged

Conversation

pierDipi
Copy link
Member

@pierDipi pierDipi commented Nov 5, 2021

The diff won't make sense but there is a non-visible character in
between _<hostname>_: and _<port>_.

Proposed Changes

  • Remove unicode control characters in Strimzi operator YAML

Release Note

None

Docs

None

Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 5, 2021
@knative-prow-robot knative-prow-robot added area/test approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 5, 2021
@pierDipi pierDipi requested review from matzew and aliok November 5, 2021 08:28
@codecov
Copy link

codecov bot commented Nov 5, 2021

Codecov Report

Merging #1414 (ba5f481) into main (e54534f) will decrease coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1414      +/-   ##
============================================
- Coverage     76.43%   76.24%   -0.19%     
  Complexity      584      584              
============================================
  Files            98       98              
  Lines          3632     3658      +26     
  Branches        166      166              
============================================
+ Hits           2776     2789      +13     
- Misses          643      653      +10     
- Partials        213      216       +3     
Flag Coverage Δ
java-unittests 82.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
control-plane/pkg/reconciler/source/controller.go 72.34% <0.00%> (-27.66%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e54534f...ba5f481. Read the comment docs.

@matzew
Copy link
Contributor

matzew commented Nov 9, 2021

/lgtm
/approve

While we are removing it here. Should we follow up on this, by filing an issue directly for Strimzi - So that folks like @ppatierno, @tombentley or @scholzj see it too ?

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 9, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@scholzj
Copy link

scholzj commented Nov 9, 2021

@matzew I already removed it in strimzi/strimzi-kafka-operator#5839. So it should be removed in 0.27 release.

@knative-prow-robot knative-prow-robot merged commit 6eedbc2 into knative-extensions:main Nov 9, 2021
@pierDipi pierDipi deleted the KNATIVE_remove-chars branch November 9, 2021 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants