Better naming and consistency for config.Env and broker.Config

[aliok]

Proposed Changes

• Better naming and consistency for config.Env
• Got rid of broker.Config which only had 1 additional field. That broker.Config thing was used in source, channel and sink. Changed those usages to config.Env.

Release Note

Docs

[google-cla]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

[knative-metrics-robot]

The following is the coverage report on the affected files.
Say /test pull-knative-sandbox-eventing-kafka-broker-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
control-plane/pkg/reconciler/kafka/topic.go	100.0%	97.5%	-2.5

[codecov]

Codecov Report

Merging #1419 (22d02a4) into main (b5df8b6) will not change coverage.
The diff coverage is 48.71%.

@@            Coverage Diff            @@
##               main    #1419   +/-   ##
=========================================
  Coverage     71.41%   71.41%           
  Complexity      584      584           
=========================================
  Files           100      100           
  Lines          3964     3964           
  Branches        166      166           
=========================================
  Hits           2831     2831           
  Misses          915      915           
  Partials        218      218           

Flag	Coverage Δ
java-unittests	82.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...lane/pkg/reconciler/base/receiver_condition_set.go	0.00% <0.00%> (ø)
control-plane/pkg/reconciler/channel/channel.go	0.00% <0.00%> (ø)
control-plane/pkg/reconciler/sink/kafka_sink.go	67.83% <50.00%> (ø)
control-plane/pkg/reconciler/broker/broker.go	70.44% <66.66%> (ø)
control-plane/pkg/reconciler/broker/controller.go	76.05% <66.66%> (ø)
control-plane/pkg/reconciler/trigger/trigger.go	70.83% <80.00%> (ø)
control-plane/pkg/reconciler/channel/controller.go	85.71% <100.00%> (ø)
control-plane/pkg/reconciler/sink/controller.go	72.34% <100.00%> (ø)
control-plane/pkg/reconciler/source/source.go	57.69% <100.00%> (ø)
control-plane/pkg/reconciler/trigger/controller.go	85.07% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5df8b6...22d02a4. Read the comment docs.

[pierDipi]

/lgtm

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [aliok,pierDipi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment