Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NT: We are testing the v1, renaming to proper name #1459

Conversation

matzew
Copy link
Contributor

@matzew matzew commented Nov 10, 2021

Signed-off-by: Matthias Wessendorf mwessend@redhat.com

Fixes #

Proposed Changes

  • renaming conformance test functions

Release Note


Docs

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 10, 2021
@knative-prow-robot knative-prow-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/test labels Nov 10, 2021
@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 10, 2021
@codecov
Copy link

codecov bot commented Nov 10, 2021

Codecov Report

Merging #1459 (4d30410) into main (09d6a05) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 4d30410 differs from pull request most recent head 990aac4. Consider uploading reports for the commit 990aac4 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1459      +/-   ##
============================================
- Coverage     73.43%   73.41%   -0.02%     
+ Complexity      583      575       -8     
============================================
  Files           101      100       -1     
  Lines          3975     3942      -33     
  Branches        165      160       -5     
============================================
- Hits           2919     2894      -25     
+ Misses          818      808      -10     
- Partials        238      240       +2     
Flag Coverage Δ
java-unittests 82.16% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
control-plane/pkg/reconciler/source/source.go 57.69% <0.00%> (-3.97%) ⬇️
...ive/eventing/kafka/broker/core/AsyncCloseable.java 63.63% <0.00%> (-3.04%) ⬇️
...g/kafka/broker/receiver/impl/ReceiverVerticle.java 97.43% <0.00%> (-0.24%) ⬇️
...lane/pkg/reconciler/base/receiver_condition_set.go 0.00% <0.00%> (ø)
...broker/dispatcher/impl/consumer/OffsetManager.java 100.00% <0.00%> (ø)
...receiver/impl/handler/MethodNotAllowedHandler.java 100.00% <0.00%> (ø)
...ver/impl/handler/ControlPlaneProbeRequestUtil.java
control-plane/pkg/reconciler/channel/channel.go 30.07% <0.00%> (+0.11%) ⬆️
...patcher/impl/consumer/OrderedConsumerVerticle.java 90.38% <0.00%> (+3.34%) ⬆️
...dispatcher/impl/consumer/BaseConsumerVerticle.java 93.10% <0.00%> (+5.60%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51d508d...990aac4. Read the comment docs.

@knative-prow-robot knative-prow-robot added area/control-plane and removed lgtm Indicates that a PR is ready to be merged. labels Nov 10, 2021
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@matzew matzew force-pushed the rename_conformance_test_funcs branch from 4d30410 to 990aac4 Compare November 16, 2021 14:48
@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 16, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 30b00b8 into knative-extensions:main Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane area/test cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants