Using a CONST for the default delivery order of events #1496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
knative-prow-robot
added
area/control-plane
approved
|
/assign @pierDipi |
Codecov Report
@@ Coverage Diff @@
## main #1496 +/- ##
============================================
- Coverage 73.48% 73.43% -0.06%
+ Complexity 585 583 -2
============================================
Files 101 101
Lines 3975 3975
Branches 165 165
============================================
- Hits 2921 2919 -2
- Misses 815 818 +3
+ Partials 239 238 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
pierDipi
approved these changes
Nov 17, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Webhook EOF error, mitigation is coming in the next deps upgrade from knative/eventing#5911 |
|
/retest |
|
/retest
…On Wed, Nov 17, 2021 at 4:52 PM Knative Prow Robot ***@***.***> wrote:
@matzew <https://github.com/matzew>: The following test *failed*, say
/retest to rerun all failed tests or /retest-required to rerun all
mandatory failed tests:
Test name Commit Details Required Rerun command
pull-knative-sandbox-eventing-kafka-broker-integration-tests 48bf519
<48bf519>
link
<https://prow.knative.dev/view/gs/knative-prow/pr-logs/pull/knative-sandbox_eventing-kafka-broker/1496/pull-knative-sandbox-eventing-kafka-broker-integration-tests/1460989148176322560>
unknown /test pull-knative-sandbox-eventing-kafka-broker-integration-tests
Full PR test history
<https://gubernator.knative.dev/pr/knative-sandbox_eventing-kafka-broker/1496>.
Your PR dashboard <https://gubernator.knative.dev/pr/matzew>.
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/guide/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://go.k8s.io/bot-commands>.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#1496 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIBMSGIWQK3623HNRKTEJTTUMPFUPANCNFSM5IGRPYXA>
.
--
Pierangelo Di Pilato
Software Engineer
Red Hat, Inc
https://www.redhat.com/
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Matthias Wessendorf mwessend@redhat.com
Fixes #
Proposed Changes
Release Note
Docs