Fix flaky tracing test #1506
Merged
Fix flaky tracing test #1506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we install the source and the sink in the same `rekt` phase we might start sending events before the sink is actually ready to accept them. Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>
knative-prow-robot
added
area/test
size/XS
Codecov Report
@@ Coverage Diff @@
## main #1506 +/- ##
============================================
+ Coverage 73.33% 73.45% +0.12%
- Complexity 586 588 +2
============================================
Files 102 103 +1
Lines 3986 3993 +7
Branches 165 165
============================================
+ Hits 2923 2933 +10
+ Misses 825 821 -4
- Partials 238 239 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we install the source and the sink in the same
rektphasewe might start sending events before the sink is actually ready
to accept them.
See also this comment: #1205 (comment)
Fixes #1205
Proposed Changes
Release Note
Docs