Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upgrade test script placeholder #1529

Conversation

pierDipi
Copy link
Member

To unblock other PRs, I'm adding a script that will make the upgrade
test job green.

Proposed Changes

  • Add upgrade test script placeholder

Release Note

None

Docs

None

Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 23, 2021
@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/test approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 23, 2021
@pierDipi
Copy link
Member Author

/cc @aliok @matzew @devguyio

@codecov
Copy link

codecov bot commented Nov 23, 2021

Codecov Report

Merging #1529 (db61b08) into main (dd93416) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1529      +/-   ##
============================================
- Coverage     73.69%   73.64%   -0.05%     
+ Complexity      588      586       -2     
============================================
  Files           107      107              
  Lines          4128     4128              
  Branches        165      165              
============================================
- Hits           3042     3040       -2     
- Misses          844      847       +3     
+ Partials        242      241       -1     
Flag Coverage Δ
java-unittests 82.00% <ø> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...dispatcher/impl/consumer/BaseConsumerVerticle.java 87.50% <0.00%> (-6.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd93416...db61b08. Read the comment docs.

@pierDipi
Copy link
Member Author

    operation.go:123: Failed while waiting for 1 endpoints in service trans-pod: did not reach the desired number of endpoints, got: 0: endpoints "trans-pod" not found

/retest

Copy link
Member

@aliok aliok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 23, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 9f26365 into knative-extensions:main Nov 23, 2021
@pierDipi pierDipi deleted the KNATIVE_upgrade-tests-placeholder branch November 29, 2021 15:11
@pierDipi
Copy link
Member Author

/cherry-pick release-0.26

@knative-prow-robot
Copy link
Contributor

@pierDipi: new pull request created: #1553

In response to this:

/cherry-pick release-0.26

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierDipi
Copy link
Member Author

pierDipi commented Feb 1, 2022

/cherry-pick release-1.0

@knative-prow-robot
Copy link
Contributor

@pierDipi: #1529 failed to apply on top of branch "release-1.0":

Applying: Add upgrade test script placeholder
.git/rebase-apply/patch:13: new blank line at EOF.
+
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
CONFLICT (add/add): Merge conflict in test/e2e-upgrade-tests.sh
Auto-merging test/e2e-upgrade-tests.sh
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Add upgrade test script placeholder
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants