Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel to use new configmap format for bootstrap servers #1558

Merged

Conversation

aliok
Copy link
Member

@aliok aliok commented Dec 1, 2021

Fixes #

Proposed Changes

  • Channel to use new configmap format for bootstrap servers
  • Nothing else is used from configmap at this moment (no auth etc.)

Release Note


Docs

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Dec 1, 2021
@knative-prow-robot knative-prow-robot added area/control-plane size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 1, 2021
@aliok aliok force-pushed the 2021-12-01-ch-use-configmap branch from 06d9152 to f630a8d Compare December 1, 2021 09:24
@aliok aliok requested a review from pierDipi December 1, 2021 09:24
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-sandbox-eventing-kafka-broker-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
control-plane/pkg/reconciler/channel/channel.go 77.3% 77.2% -0.1
control-plane/pkg/reconciler/kafka/topic.go 94.9% 84.8% -10.1

@codecov
Copy link

codecov bot commented Dec 1, 2021

Codecov Report

Merging #1558 (f630a8d) into main (1a38db0) will decrease coverage by 0.21%.
The diff coverage is 48.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1558      +/-   ##
============================================
- Coverage     75.21%   75.00%   -0.22%     
  Complexity      592      592              
============================================
  Files           107      107              
  Lines          4124     4136      +12     
  Branches        170      170              
============================================
  Hits           3102     3102              
- Misses          764      776      +12     
  Partials        258      258              
Flag Coverage Δ
java-unittests 82.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
control-plane/pkg/reconciler/kafka/topic.go 80.68% <7.69%> (-12.74%) ⬇️
control-plane/pkg/reconciler/channel/channel.go 58.20% <91.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a38db0...f630a8d. Read the comment docs.

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Great to see this consolidation!

zap.Any("replicationFactor", config.BootstrapServers),
zap.Any("bootstrapServers", config.BootstrapServers),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 0114a34 into knative-extensions:main Dec 1, 2021
@aliok aliok deleted the 2021-12-01-ch-use-configmap branch December 1, 2021 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants