ConsumerGroup reconciler

[pierDipi]

Part of #1537

Proposed Changes

• Add ConsumerGroup reconciler

Release Note

None

Docs

None

TODO: reconciler tests (follow-up PR)

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [pierDipi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[devguyio]

/assign

[codecov]

Codecov Report

Merging #1562 (22319b5) into main (e956d93) will decrease coverage by 0.74%.
The diff coverage is 67.85%.

@@             Coverage Diff              @@
##               main    #1562      +/-   ##
============================================
- Coverage     75.37%   74.63%   -0.75%     
  Complexity      592      592              
============================================
  Files           106      116      +10     
  Lines          4167     4207      +40     
  Branches        170      170              
============================================
- Hits           3141     3140       -1     
- Misses          766      809      +43     
+ Partials        260      258       -2     

Flag	Coverage Δ
java-unittests	82.06% <ø> (+0.05%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...afka/eventing/v1alpha1/consumer_group_lifecycle.go	0.00% <0.00%> (ø)
...ls/kafka/eventing/v1alpha1/consumer_group_types.go	0.00% <0.00%> (ø)
...nternals/kafka/eventing/v1alpha1/consumer_types.go	0.00% <0.00%> (ø)
...apis/internals/kafka/eventing/v1alpha1/register.go	0.00% <ø> (ø)
...rnals/kafka/eventing/v1alpha1/consumer_defaults.go	100.00% <100.00%> (ø)
...kafka/eventing/v1alpha1/consumer_group_defaults.go	100.00% <100.00%> (ø)
...fka/eventing/v1alpha1/consumer_group_validation.go	100.00% <100.00%> (ø)
...als/kafka/eventing/v1alpha1/consumer_validation.go	100.00% <100.00%> (ø)
control-plane/pkg/reconciler/kafka/topic.go	80.68% <0.00%> (-12.74%)	⬇️
control-plane/pkg/reconciler/broker/broker.go	66.85% <0.00%> (-5.75%)	⬇️
... and 8 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e956d93...22319b5. Read the comment docs.

[knative-metrics-robot]

The following is the coverage report on the affected files.
Say /test pull-knative-sandbox-eventing-kafka-broker-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
control-plane/pkg/apis/internals/kafka/eventing/v1alpha1/consumer_defaults.go	Do not exist	100.0%
control-plane/pkg/apis/internals/kafka/eventing/v1alpha1/consumer_group_defaults.go	Do not exist	100.0%
control-plane/pkg/apis/internals/kafka/eventing/v1alpha1/consumer_group_lifecycle.go	Do not exist	0.0%
control-plane/pkg/apis/internals/kafka/eventing/v1alpha1/consumer_group_types.go	Do not exist	0.0%
control-plane/pkg/apis/internals/kafka/eventing/v1alpha1/consumer_group_validation.go	Do not exist	100.0%
control-plane/pkg/apis/internals/kafka/eventing/v1alpha1/consumer_types.go	Do not exist	0.0%
control-plane/pkg/apis/internals/kafka/eventing/v1alpha1/consumer_validation.go	Do not exist	100.0%
control-plane/pkg/apis/internals/kafka/eventing/v1alpha1/register.go	Do not exist	0.0%

[aavarghese]

Changes look good.
Q: Will the scheduling of cg.Spec.Replicas and descheduling of nConsumers-*cg.Spec.Replicas be done in a separate PR?

[pierDipi]

Yes, scheduling will be done in a separate PR

[pierDipi]

Friendly ping @devguyio

[devguyio]

/lgtm

[knative-prow-robot]

@pierDipi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-knative-sandbox-eventing-kafka-broker-go-coverage	22319b5	link	false	/test pull-knative-sandbox-eventing-kafka-broker-go-coverage

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.