-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[main] Use Broker's own configmap for Kafka #1591
[main] Use Broker's own configmap for Kafka #1591
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1591 +/- ##
============================================
+ Coverage 74.87% 74.92% +0.04%
- Complexity 595 597 +2
============================================
Files 116 116
Lines 4211 4211
Branches 171 171
============================================
+ Hits 3153 3155 +2
+ Misses 802 799 -3
- Partials 256 257 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mgencur, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-0.26 |
@pierDipi: once the present PR merges, I will cherry-pick it on top of release-0.26 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-1.0 |
@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.0 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@pierDipi: new pull request created: #1592 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@pierDipi: new pull request created: #1593 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes an issue with using wrong default values when
config-br-defaults
configmap points to another cluster-default configmap that might not include configuration for Kafka. It might include for example MTChannelBasedBroker configuration in which case the Broker creation fails with an error like thisProposed Changes
Release Note
Docs