Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Vertx core metrics in Prometheus format #231

Conversation

pierDipi
Copy link
Member

@pierDipi pierDipi commented Sep 29, 2020

This PR exposes Vertx core metrics in Prometheus format and add
notes on how to configure Prometheus to scrape data plane pods.

Spec metrics in a separate PR.

Signed-off-by: Pierangelo Di Pilato pierangelodipilato@gmail.com

Part of #227

Proposed Changes

  • Expose Vertx core metrics in Prometheus format

Prometheus dashboard

image

Release Note

- 🎁 Add new feature
Data plane pods expose server and client metrics in Prometheus format.

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 29, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 29, 2020
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 29, 2020
Copy link
Contributor

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Produced via:
prettier --write --prose-wrap=always $(find -name '*.md' | grep -v vendor | grep -v .github | grep -v docs/cmd/)

@pierDipi
Copy link
Member Author

Waiting for the release!
/hold

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 29, 2020
@codecov
Copy link

codecov bot commented Sep 29, 2020

Codecov Report

Merging #231 into master will decrease coverage by 0.03%.
The diff coverage is 53.84%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #231      +/-   ##
============================================
- Coverage     76.44%   76.40%   -0.04%     
- Complexity      166      170       +4     
============================================
  Files            48       49       +1     
  Lines          1401     1420      +19     
  Branches         46       46              
============================================
+ Hits           1071     1085      +14     
- Misses          261      266       +5     
  Partials         69       69              
Flag Coverage Δ Complexity Δ
#java-unittests 76.25% <53.84%> (-0.08%) 170.00 <4.00> (+4.00) ⬇️
#unittests 76.40% <53.84%> (-0.04%) 170.00 <4.00> (+4.00) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...knative/eventing/kafka/broker/dispatcher/Main.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...v/knative/eventing/kafka/broker/receiver/Main.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ka/broker/core/metrics/MetricsOptionsProvider.java 88.88% <88.88%> (ø) 1.00 <1.00> (?)
...tive/eventing/kafka/broker/core/utils/BaseEnv.java 100.00% <100.00%> (ø) 7.00 <3.00> (+3.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b457e64...2ee1a6b. Read the comment docs.

Copy link
Contributor

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Produced via:
prettier --write --prose-wrap=always $(find -name '*.md' | grep -v vendor | grep -v .github | grep -v docs/cmd/)

@pierDipi pierDipi force-pushed the prometheus-vertx-internal branch 2 times, most recently from c07a3ec to 3d1ee11 Compare September 29, 2020 14:54
@pierDipi
Copy link
Member Author

/cc slinkydeveloper

data-plane/receiver/pom.xml Outdated Show resolved Hide resolved
data-plane/receiver/pom.xml Outdated Show resolved Hide resolved
data-plane/dispatcher/pom.xml Outdated Show resolved Hide resolved
data-plane/dispatcher/pom.xml Outdated Show resolved Hide resolved
data-plane/pom.xml Outdated Show resolved Hide resolved
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 30, 2020
This PR exposes Vertx core metrics in prometheus format and add
notes on how to configure prometheus to scrape data plane pods.

Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 30, 2020
@slinkydeveloper
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2020
@pierDipi
Copy link
Member Author

/unhold

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 30, 2020
@knative-prow-robot knative-prow-robot merged commit bb434dd into knative-extensions:master Sep 30, 2020
@pierDipi pierDipi deleted the prometheus-vertx-internal branch April 14, 2021 21:16
matzew added a commit to matzew/eventing-kafka-broker that referenced this pull request May 4, 2022
Install no serving, as not needed

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
matzew added a commit to matzew/eventing-kafka-broker that referenced this pull request May 4, 2022
Install no serving, as not needed

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
matzew added a commit to matzew/eventing-kafka-broker that referenced this pull request May 10, 2022
Install no serving, as not needed

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
matzew added a commit to matzew/eventing-kafka-broker that referenced this pull request May 10, 2022
Install no serving, as not needed

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
matzew added a commit to matzew/eventing-kafka-broker that referenced this pull request May 16, 2022
…extensions#233)

Install no serving, as not needed

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants