New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose Vertx core metrics in Prometheus format #231
Expose Vertx core metrics in Prometheus format #231
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Produced via:
prettier --write --prose-wrap=always $(find -name '*.md' | grep -v vendor | grep -v .github | grep -v docs/cmd/)
Waiting for the release! |
Codecov Report
@@ Coverage Diff @@
## master #231 +/- ##
============================================
- Coverage 76.44% 76.40% -0.04%
- Complexity 166 170 +4
============================================
Files 48 49 +1
Lines 1401 1420 +19
Branches 46 46
============================================
+ Hits 1071 1085 +14
- Misses 261 266 +5
Partials 69 69
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
1f808b6
to
2754995
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Produced via:
prettier --write --prose-wrap=always $(find -name '*.md' | grep -v vendor | grep -v .github | grep -v docs/cmd/)
c07a3ec
to
3d1ee11
Compare
/cc slinkydeveloper |
data-plane/core/src/main/java/dev/knative/eventing/kafka/broker/core/utils/MetricsConfigs.java
Outdated
Show resolved
Hide resolved
8cb82c0
to
0e907fb
Compare
data-plane/core/src/main/java/dev/knative/eventing/kafka/broker/core/utils/BaseEnv.java
Show resolved
Hide resolved
This PR exposes Vertx core metrics in prometheus format and add notes on how to configure prometheus to scrape data plane pods. Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
Signed-off-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
13dbdaf
to
2ee1a6b
Compare
/lgtm |
/unhold |
Install no serving, as not needed Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Install no serving, as not needed Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Install no serving, as not needed Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
Install no serving, as not needed Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
…extensions#233) Install no serving, as not needed Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
This PR exposes Vertx core metrics in Prometheus format and add
notes on how to configure Prometheus to scrape data plane pods.
Spec metrics in a separate PR.
Signed-off-by: Pierangelo Di Pilato pierangelodipilato@gmail.com
Part of #227
Proposed Changes
Prometheus dashboard
Release Note