Tracing tests for Kafka Broker and Channel #2369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow
bot
added
the
do-not-merge/work-in-progress
knative-prow
bot
added
area/test
size/L
Codecov Report
@@ Coverage Diff @@
## main #2369 +/- ##
============================================
- Coverage 64.62% 64.54% -0.09%
+ Complexity 709 708 -1
============================================
Files 146 146
Lines 9806 9806
Branches 224 224
============================================
- Hits 6337 6329 -8
- Misses 3037 3046 +9
+ Partials 432 431 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. |
mgencur
force-pushed
the
broker_tracing_tests_main
branch
from
5d51cd4
to
d595fbb
Compare
knative-prow
bot
added
size/XL
mgencur
changed the title
5 tasks
|
This PR needs to wait for an updated dependency on knative/eventing (#2357) |
mgencur
force-pushed
the
broker_tracing_tests_main
branch
from
2914fdb
to
a434369
Compare
mgencur
changed the title
knative-prow
bot
added
size/XXL
|
/retest-required |
1 similar comment
|
/retest-required |
|
@pierDipi Hi! This one is ready for review. Whenever you have time. Thanks :) |
pierDipi
reviewed
Jul 27, 2022
include/google/protobuf/any.proto
Outdated
| @@ -0,0 +1,158 @@ | |||
| // Protocol Buffers - Google's data interchange format | |||
There was a problem hiding this comment.
I didn't fully get why we have all of these proto files, would you mind expanding?
There was a problem hiding this comment.
Hi @pierDipi these files got in by running ./hack/update-codegen.sh. They're probably not related to this PR. Let me rebase and see if this is still required.
There was a problem hiding this comment.
OK. The codegen check now passes without those files. So, this PR doesn't include them anymore.
knative-prow-robot
added
the
needs-rebase
mgencur
force-pushed
the
broker_tracing_tests_main
branch
from
3bf14b6
to
0b62f28
Compare
knative-prow-robot
removed
the
needs-rebase
knative-prow
bot
added
size/XL
|
/retest-required |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aliok, mgencur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
|
Thank you @mgencur! |
mgencur
added a commit
to mgencur/eventing-kafka-broker
that referenced
this pull request
Aug 2, 2022
mgencur
added a commit
to mgencur/eventing-kafka-broker
that referenced
this pull request
Aug 2, 2022
knative-prow bot
pushed a commit
that referenced
this pull request
Aug 2, 2022
* Tracing tests for Kafka Broker (#2369) * Manually update deps ./hack/update-deps.sh --upgrade --release 1.5 --domain knative.dev/eventing
mgencur
added a commit
to mgencur/eventing-kafka-broker
that referenced
this pull request
Aug 2, 2022
openshift-ci bot
pushed a commit
to openshift-knative/eventing-kafka-broker
that referenced
this pull request
Aug 3, 2022
* OpenShift Script changes * Tracing tests for Kafka Broker (knative-extensions#2369) * Manually update deps ./hack/update-deps.sh --upgrade --release 1.5 --domain knative.dev/eventing * Reuse tracing and KnativeKafka installation from serverless-operator
mgencur
added a commit
to mgencur/eventing-kafka-broker
that referenced
this pull request
Aug 17, 2022
knative-prow bot
pushed a commit
that referenced
this pull request
Aug 18, 2022
* Tracing tests for Kafka Broker (#2369) * Manually update deps ./hack/update-deps.sh --upgrade --release 1.6 --domain knative.dev/eventing * Fix formatting for sacura_test.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #585
This PR still has vendor/knative.dev/pkg/test/tracing/traces.go in vendor directory. It's a copy of this file from knative/eventing with slight changes. I plan to send a PR to knative.dev/pkg and then vendor this file to this repository.
EDIT: Sent knative/eventing#6446 which was merged and this PR has been rebased.
Proposed Changes
Release Note
Docs